Bug 11208 - Multi transport types: a sms message without sms number should be marked as failed
Summary: Multi transport types: a sms message without sms number should be marked as f...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 9016
Blocks: 11209
  Show dependency treegraph
 
Reported: 2013-11-06 14:22 UTC by Jonathan Druart
Modified: 2014-12-07 20:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11208: If no smsalertnumber is defined, the message is marked as failed (1.24 KB, patch)
2013-11-06 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11208: If no smsalertnumber is defined, the message is marked as failed (1.29 KB, patch)
2013-12-27 20:52 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11208: If no smsalertnumber is defined, the message is marked as failed (1.51 KB, patch)
2013-12-28 14:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-11-06 14:22:45 UTC

    
Comment 1 Jonathan Druart 2013-11-06 14:23:17 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-12-27 20:52:17 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-12-28 14:51:47 UTC
Created attachment 23841 [details] [review]
[PASSED QA] Bug 11208: If no smsalertnumber is defined, the message is marked as failed

For DUE message (and PREDUE, etc.) there are no check before sending the
message to the message_queue table.

This check avoids to try to send again and again the same message. Now
it is marked as "failed".

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Without the patch a sms notice will remain as 'pending' forever.
With the patch applied, the status is set to 'failed'.

Passes all tests and QA script.
Comment 4 Galen Charlton 2013-12-30 16:49:16 UTC
Pushed to master, along with a patch that adds a regression test.  Thanks, Jonathan!