Bugzilla – Attachment 24464 Details for
Bug 10987
Too many 'see also' and 'usedfor/see from' labels occurences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap)
Bug-10987-Too-many-see-also-and-see-from-labels-oc.patch (text/plain), 8.37 KB, created by
Jonathan Druart
on 2014-01-16 15:59:40 UTC
(
hide
)
Description:
Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-01-16 15:59:40 UTC
Size:
8.37 KB
patch
obsolete
>From 5917b2d201ab0d6cd2524e9f47c4e0a7e342329a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 2 Oct 2013 15:42:13 -0300 >Subject: [PATCH] Bug 10987: Too many 'see also' and 'see from' labels > occurences (rebased+bootstrap) > >If an authority record has more than one 4xx$a (or 5xx$a) entries the >corresponding labels 'see also' and 'used for/see from' are repeated. > >To test: >- Have authority records with more than one entry on the 4xx (or 5xx) fields. >- Do a search, check "see also:" (or 'used for/see from') appear more than once. >- Apply the patch >- Reload and check it looks nicer :-D >- Repeat for: staff auth search, opac using ccsr, opac using prog >- Signoff > >Regards >To+ > >Sponsored-by: Universidad Nacional de Cordoba > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Work as decribed. No koha-qa errors >Nice view on staff and both opac > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > .../intranet-tmpl/prog/en/css/staff-global.css | 6 ++++-- > .../en/includes/authorities-search-results.inc | 21 ++++++++++---------- > .../en/includes/authorities-search-results.inc | 8 ++------ > koha-tmpl/opac-tmpl/ccsr/en/css/opac.css | 6 ++++-- > koha-tmpl/opac-tmpl/prog/en/css/opac.css | 6 ++++-- > .../en/includes/authorities-search-results.inc | 21 ++++++++++---------- > 6 files changed, 34 insertions(+), 34 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index 1f8ea3f..ba49c88 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -2267,11 +2267,13 @@ ul.ui-tabs-nav li { > } > > .authref { >- text-indent: 2em; >+ font-style: normal; >+ text-indent: 4em; > } > >-.authref .label { >+.seefrom, .seealso { > font-style: italic; >+ text-indent: 2em; > } > > #authfinderops { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >index 7d96264..baea979 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >@@ -21,13 +21,6 @@ > <span class="RT">RT: [% heading | html %]</span> > [% END %] > [% ELSE %] >- <span class="label"> >- [% IF ( linkType=='seefrom' ) %] >- used for/see from: >- [% ELSIF ( linkType=='seealso' ) %] >- see also: >- [% END %] >- </span> > <span class="heading"> > [% IF ( linkType=='seealso' ) %] > [% IF ( authid ) %] >@@ -98,9 +91,11 @@ > </div> > [% END %] > [% ELSE %] >- [% IF ( summary.seefrom ) %] >+ [% IF ( summary.seefrom.size > 1 ) %] >+ <div class="seefrom"> >+ <span class="seefrom">used for/see from:</span> > [% FOREACH seefro IN summary.seefrom %] >- <div class="seefrom authref"> >+ <div class="authref"> > [% PROCESS showreference > heading=seefro.heading > linkType='seefrom' >@@ -109,10 +104,13 @@ > %] > </div> > [% END %] >+ </div> > [% END %] >- [% IF ( summary.seealso ) %] >+ [% IF ( summary.seealso.size > 1 ) %] >+ <div class="seealso"> >+ <span class="seealso">see also:</span> > [% FOREACH seeals IN summary.seealso %] >- <div class="seealso authref"> >+ <div class="authref"> > [% PROCESS showreference > heading=seeals.heading > linkType='seealso' >@@ -121,6 +119,7 @@ > %] > </div> > [% END %] >+ </div> > [% END %] > [% END %] > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc >index 6a9f9d0..d9d967f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authorities-search-results.inc >@@ -20,12 +20,6 @@ > <span class="RT">RT: [% heading | html %]</span> > [% END %] > [% ELSE %] >- <span class="label"> >- [% IF ( linkType=='seefrom' ) %] >- used for/see from: >- [% ELSIF ( linkType=='seealso' ) %] >- see also: >- [% END %] > <span class="heading"> > [% IF ( linkType=='seealso' ) %] > [% IF ( authid ) %] >@@ -90,6 +84,7 @@ > [% END %] > [% ELSE %] > [% IF ( summary.seefrom ) %] >+ <span class="seefrom">used for/see from:</span> > [% FOREACH seefro IN summary.seefrom %] > <div class="seefrom authref"> > [% PROCESS showreference >@@ -101,6 +96,7 @@ > [% END %] > [% END %] > [% IF ( summary.seealso ) %] >+ <span class="seealso">see also:</span> > [% FOREACH seeals IN summary.seealso %] > <div class="seealso authref"> > [% PROCESS showreference >diff --git a/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css b/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css >index 0901d6b..f0b8744 100644 >--- a/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css >+++ b/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css >@@ -2640,11 +2640,13 @@ ul.ui-tabs-nav li { > } > > .authref { >- text-indent: 2em; >+ font-style: normal; >+ text-indent: 4em; > } > >-.authref .label { >+.seefrom, .seealso { > font-style: italic; >+ text-indent: 2em; > } > > .authstanza { >diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css >index b7cf025..7cbd7ec 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css >+++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css >@@ -2779,11 +2779,13 @@ ul.ui-tabs-nav li { > } > > .authref { >- text-indent: 2em; >+ font-style: normal; >+ text-indent: 4em; > } > >-.authref .label { >+.seefrom, .seealso { > font-style: italic; >+ text-indent: 2em; > } > > .authstanza { >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc b/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >index dcd2efc..303d534 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >@@ -20,13 +20,6 @@ > <span class="RT">RT: [% heading | html %]</span> > [% END %] > [% ELSE %] >- <span class="label"> >- [% IF ( linkType=='seefrom' ) %] >- used for/see from: >- [% ELSIF ( linkType=='seealso' ) %] >- see also: >- [% END %] >- </span> > <span class="heading"> > [% IF ( linkType=='seealso' ) %] > [% IF ( authid ) %] >@@ -97,9 +90,11 @@ > </div> > [% END %] > [% ELSE %] >- [% IF ( summary.seefrom ) %] >+ [% IF ( summary.seefrom.size > 1 ) %] >+ <div class="seefrom"> >+ <span class="seefrom">used for/see from:</span> > [% FOREACH seefro IN summary.seefrom %] >- <div class="seefrom authref"> >+ <div class="authref"> > [% PROCESS showreference > heading=seefro.heading > linkType='seefrom' >@@ -108,10 +103,13 @@ > %] > </div> > [% END %] >+ </div> > [% END %] >- [% IF ( summary.seealso ) %] >+ [% IF ( summary.seealso.size > 1 ) %] >+ <div class="seealso"> >+ <span class="seealso">see also:</span> > [% FOREACH seeals IN summary.seealso %] >- <div class="seealso authref"> >+ <div class="authref"> > [% PROCESS showreference > heading=seeals.heading > linkType='seealso' >@@ -120,6 +118,7 @@ > %] > </div> > [% END %] >+ </div> > [% END %] > [% END %] > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10987
:
21733
|
21897
|
22788
|
23399
| 24464