Bug 10987 - Too many 'see also' and 'usedfor/see from' labels occurences
Summary: Too many 'see also' and 'usedfor/see from' labels occurences
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 10691
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-02 18:51 UTC by Tomás Cohen Arazi
Modified: 2014-12-07 20:07 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10987: Too many 'see also' and 'see from' labels occurences (6.69 KB, patch)
2013-10-02 18:53 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10987: Too many 'see also' and 'see from' labels occurences (6.80 KB, patch)
2013-10-09 12:12 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 10987: Too many 'see also' and 'see from' labels occurences (6.85 KB, patch)
2013-11-07 16:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap) (8.37 KB, patch)
2013-12-11 15:48 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap) (8.37 KB, patch)
2014-01-16 15:59 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-10-02 18:51:41 UTC
If you do an authority search and the results contain authorities with more than one 4xx or 5xx the 'see also' and 'used for/see from' labels are unnecesarilly repeated, affecting readability.
Comment 1 Tomás Cohen Arazi 2013-10-02 18:53:03 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-10-03 07:02:56 UTC
Patch applied cleanly, go forth and signoff
Comment 3 Bernardo Gonzalez Kriegel 2013-10-09 12:12:51 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-11-07 13:41:12 UTC
Tomás, the patch does not apply anymore, could you rebase it please?

fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc).
Comment 5 Jonathan Druart 2013-11-07 13:41:52 UTC
I forgot the dependency! Sorry.
Comment 6 Jonathan Druart 2013-11-07 16:11:40 UTC
Tested with bug 10691. Works great.
Marked as Passed QA.
Comment 7 Jonathan Druart 2013-11-07 16:12:42 UTC Comment hidden (obsolete)
Comment 8 Tomás Cohen Arazi 2013-12-11 15:48:19 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2014-01-16 15:57:31 UTC
Tested on top of bug 10691. All works great. Maybe it would be better to split patches for the OPAC.

Marked as Passed QA.
Comment 10 Jonathan Druart 2014-01-16 15:59:40 UTC
Created attachment 24464 [details] [review]
Bug 10987: Too many 'see also' and 'see from' labels occurences (rebased+bootstrap)

If an authority record has more than one 4xx$a (or 5xx$a) entries the
corresponding labels 'see also' and 'used for/see from' are repeated.

To test:
- Have authority records with more than one entry on the 4xx (or 5xx) fields.
- Do a search, check "see also:" (or 'used for/see from') appear more than once.
- Apply the patch
- Reload and check it looks nicer :-D
- Repeat for: staff auth search, opac using ccsr, opac using prog
- Signoff

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Work as decribed. No koha-qa errors
Nice view on staff and both opac

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 11 Galen Charlton 2014-01-16 23:10:35 UTC
Pushed to master, along with a follow-up that repairs breakage in the display of an authority record that has only one 4XX, or one 5XX.

Thanks, Tomás!