Attachment 2526 Details for Bug 5140 – Proposed fix

[patch] Proposed fix

0001-Fix-for-Bug-5140-In-Chrome-drop-down-menus-disappear.patch (text/plain), 4.31 KB, created by Owen Leonard on 2010-08-16 19:12:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2010-08-16 19:12:23 UTC

Size: 4.31 KB

patch

obsolete

>From 9fd9adff314b03501b434b6c0656e33ccebcb9bc Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 16 Aug 2010 15:07:43 -0400
>Subject: [PATCH] Fix for Bug 5140 - In Chrome, drop-down menus disappear after using pop-up calendar
>
>Disabling that part of the calendar JavaScript which hides
><select> form fields when the calendar is displayed. This is at
>the expense of IE6.
>---
> .../intranet-tmpl/prog/en/lib/calendar/calendar.js |   10 +++++-----
> .../opac-tmpl/prog/en/lib/calendar/calendar.js     |   14 +++++++-------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/lib/calendar/calendar.js b/koha-tmpl/intranet-tmpl/prog/en/lib/calendar/calendar.js
>index 028ad4a..bac31ab 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/lib/calendar/calendar.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/lib/calendar/calendar.js
>@@ -1200,7 +1200,7 @@ Calendar.prototype.callCloseHandler = function () {
> 	if (this.onClose) {
> 		this.onClose(this);
> 	}
>-	this.hideShowCovered();
>+	// this.hideShowCovered();
> };
> 
> /** Removes the calendar object from the DOM tree and destroys it. */
>@@ -1258,7 +1258,7 @@ Calendar.prototype.show = function () {
> 		Calendar.addEvent(document, "keypress", Calendar._keyEvent);
> 		Calendar.addEvent(document, "mousedown", Calendar._checkCalendar);
> 	}
>-	this.hideShowCovered();
>+	// this.hideShowCovered();
> };
> 
> /**
>@@ -1273,7 +1273,7 @@ Calendar.prototype.hide = function () {
> 	}
> 	this.element.style.display = "none";
> 	this.hidden = true;
>-	this.hideShowCovered();
>+	// this.hideShowCovered();
> };
> 
> /**
>@@ -1463,7 +1463,7 @@ Calendar.prototype.parseDate = function (str, fmt) {
> 	}
> };
> 
>-Calendar.prototype.hideShowCovered = function () {
>+/* Calendar.prototype.hideShowCovered = function () {
> 	var self = this;
> 	Calendar.continuation_for_the_fucking_khtml_browser = function() {
> 		function getVisib(obj){
>@@ -1523,7 +1523,7 @@ Calendar.prototype.hideShowCovered = function () {
> 		setTimeout("Calendar.continuation_for_the_fucking_khtml_browser()", 10);
> 	else
> 		Calendar.continuation_for_the_fucking_khtml_browser();
>-};
>+}; */
> 
> /** Internal function; it displays the bar with the names of the weekday. */
> Calendar.prototype._displayWeekdays = function () {
>diff --git a/koha-tmpl/opac-tmpl/prog/en/lib/calendar/calendar.js b/koha-tmpl/opac-tmpl/prog/en/lib/calendar/calendar.js
>index 028ad4a..42dd9e3 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/lib/calendar/calendar.js
>+++ b/koha-tmpl/opac-tmpl/prog/en/lib/calendar/calendar.js
>@@ -472,7 +472,7 @@ Calendar.calDragIt = function (ev) {
> 		posX = ev.pageX;
> 		posY = ev.pageY;
> 	}
>-	cal.hideShowCovered();
>+	// cal.hideShowCovered();
> 	var st = cal.element.style;
> 	st.left = (posX - cal.xOffs) + "px";
> 	st.top = (posY - cal.yOffs) + "px";
>@@ -490,7 +490,7 @@ Calendar.calDragEnd = function (ev) {
> 		removeEvent(document, "mouseup", calDragEnd);
> 		tableMouseUp(ev);
> 	}
>-	cal.hideShowCovered();
>+	// cal.hideShowCovered();
> };
> 
> Calendar.dayMouseDown = function(ev) {
>@@ -1200,7 +1200,7 @@ Calendar.prototype.callCloseHandler = function () {
> 	if (this.onClose) {
> 		this.onClose(this);
> 	}
>-	this.hideShowCovered();
>+	// this.hideShowCovered();
> };
> 
> /** Removes the calendar object from the DOM tree and destroys it. */
>@@ -1258,7 +1258,7 @@ Calendar.prototype.show = function () {
> 		Calendar.addEvent(document, "keypress", Calendar._keyEvent);
> 		Calendar.addEvent(document, "mousedown", Calendar._checkCalendar);
> 	}
>-	this.hideShowCovered();
>+	// this.hideShowCovered();
> };
> 
> /**
>@@ -1273,7 +1273,7 @@ Calendar.prototype.hide = function () {
> 	}
> 	this.element.style.display = "none";
> 	this.hidden = true;
>-	this.hideShowCovered();
>+	// this.hideShowCovered();
> };
> 
> /**
>@@ -1463,7 +1463,7 @@ Calendar.prototype.parseDate = function (str, fmt) {
> 	}
> };
> 
>-Calendar.prototype.hideShowCovered = function () {
>+/* Calendar.prototype.hideShowCovered = function () {
> 	var self = this;
> 	Calendar.continuation_for_the_fucking_khtml_browser = function() {
> 		function getVisib(obj){
>@@ -1523,7 +1523,7 @@ Calendar.prototype.hideShowCovered = function () {
> 		setTimeout("Calendar.continuation_for_the_fucking_khtml_browser()", 10);
> 	else
> 		Calendar.continuation_for_the_fucking_khtml_browser();
>-};
>+}; */
> 
> /** Internal function; it displays the bar with the names of the weekday. */
> Calendar.prototype._displayWeekdays = function () {
>-- 
>1.7.0.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 5140: 2525 | 2526 | 3166