Attachment 25484 Details for Bug 11796 – Bug 11796 - Results with 6 facets have missing facet

[patch] Bug 11796 - Results with 6 facets have missing facet

Bug-11796---Results-with-6-facets-have-missing-fac.patch (text/plain), 1.96 KB, created by Jonathan Druart on 2014-02-20 10:21:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-02-20 10:21:08 UTC

Size: 1.96 KB

patch

obsolete

>From 489bac837fa74c6128ebfa2423007b486b167568 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 19 Feb 2014 15:26:24 -0500
>Subject: [PATCH] Bug 11796 - Results with 6 facets have missing facet
>
>If a search gives results with 6 facets, one of those facets won't be
>displayed. This is due to a bug in the code that only considers great
>than 6 facets in one area, and less than 6 in another.
>
>Test Plan:
>1) Perform a search that should give results for 6 different libraries
>2) Note you only see 5 libraries in the facets with no option to expand
>3) Apply this patch
>4) Repeat step 1
>5) Note you now have the option to expand the facets list
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>This patch should provide a regression test but I really don't know how
>to write it.
>---
> C4/Search.pm |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Search.pm b/C4/Search.pm
>index 4e87678..6a705d9 100644
>--- a/C4/Search.pm
>+++ b/C4/Search.pm
>@@ -567,7 +567,7 @@ sub getRecords {
>                           )
>                         {
>                             $number_of_facets++;
>-                            if (   ( $number_of_facets < 6 )
>+                            if (   ( $number_of_facets <= 5 )
>                                 || ( $expanded_facet eq $link_value )
>                                 || ( $facets_info->{$link_value}->{'expanded'} )
>                               )
>@@ -644,7 +644,7 @@ sub getRecords {
>                         # handle expanded option
>                         unless ( $facets_info->{$link_value}->{'expanded'} ) {
>                             $expandable = 1
>-                              if ( ( $number_of_facets > 6 )
>+                              if ( ( $number_of_facets > 5 )
>                                 && ( $expanded_facet ne $link_value ) );
>                         }
>                         push @facets_loop,
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11796: 25466 | 25471 | 25484