Bugzilla – Attachment 26202 Details for
Bug 11760
In notices, code of road type is used instead of descritpion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11760 : In notices, code of road type is used instead of description
PASSED-QA-Bug-11760--In-notices-code-of-road-type-.patch (text/plain), 1.69 KB, created by
Katrin Fischer
on 2014-03-12 16:38:23 UTC
(
hide
)
Description:
[PASSED QA] Bug 11760 : In notices, code of road type is used instead of description
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-03-12 16:38:23 UTC
Size:
1.69 KB
patch
obsolete
>From dfcaa1d864f8b94bf7450a2726ec1daffccec808 Mon Sep 17 00:00:00 2001 >From: Sophie Meynieux <sophie.meynieux@biblibre.com> >Date: Fri, 14 Feb 2014 12:10:32 +0100 >Subject: [PATCH] [PASSED QA] Bug 11760 : In notices, code of road type is used > instead of description > >Test plan : > - Define a notice containing <<borrowers.streettype>> > - Trigger an event that generate this notice > >Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description > >This patch needs bug 7372 to be applied > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >This works as described, passes tests and QA script. > >Note: it seems it's not possible currently to use B_streettype from >the interface, but it might be worth adding it as a follow up for later >use. >--- > C4/Letters.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 6709294..5025c10 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -23,6 +23,7 @@ use warnings; > use MIME::Lite; > use Mail::Sendmail; > >+use C4::Koha qw(GetAuthorisedValueByCode); > use C4::Members; > use C4::Members::Attributes qw(GetBorrowerAttributes); > use C4::Branch; >@@ -637,6 +638,7 @@ sub _parseletter { > #Therefore adding the test on biblio. This includes biblioitems, > #but excludes items. Removed unneeded global and lookahead. > >+ $val = GetAuthorisedValueByCode ('ROADTYPE', $val, 0) if $table=~/^borrowers$/ && $field=~/^streettype$/; > my $replacedby = defined ($val) ? $val : ''; > ($letter->{title} ) and do { > $letter->{title} =~ s/$replacetablefield/$replacedby/g; >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11760
:
25254
|
25259
|
25302
|
25735
| 26202