In notices, <<borrowers.streettype>> is replaced by road type code rather than description With this patch, description is retrieved This patch needs http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372
Created attachment 25254 [details] [review] MT11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied
Created attachment 25259 [details] [review] MT11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied
On Jonathan's advice, I change the patch to be more restrictive on <<borrowers.streettype>> substitution.
Created attachment 25302 [details] [review] Bug 11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied
Typo in bug naming
Created attachment 25735 [details] [review] Bug 11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 26202 [details] [review] [PASSED QA] Bug 11760 : In notices, code of road type is used instead of description Test plan : - Define a notice containing <<borrowers.streettype>> - Trigger an event that generate this notice Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description This patch needs bug 7372 to be applied Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described, passes tests and QA script. Note: it seems it's not possible currently to use B_streettype from the interface, but it might be worth adding it as a follow up for later use.
Pushed to master. Thanks, Sophie!
Pushed to 3.14.x, will be in 3.14.08