Bugzilla – Attachment 27264 Details for
Bug 9063
When ordering from staged file '# Bibs' is empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9063: When ordering from staged file '# Bibs' is empty
SIGNED-OFF-Bug-9063-When-ordering-from-staged-file.patch (text/plain), 3.94 KB, created by
Owen Leonard
on 2014-04-17 16:26:16 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9063: When ordering from staged file '# Bibs' is empty
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-04-17 16:26:16 UTC
Size:
3.94 KB
patch
obsolete
>From 6edf723c35b50919880b41b2610403aabb7c91b8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 15 Apr 2014 16:47:20 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 9063: When ordering from staged file '# > Bibs' is empty >Content-Type: text/plain; charset="utf-8" > >Bug 2060 renames columns num_biblios with num_records in the >import_batches table. > >The addorderiso2709 files had not been fixed. > >Test plan: >Add an order from a staged file to a basket and verify the "# Bibs" >columns is correctly filled. Before the patch, the column was empty. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > acqui/addorderiso2709.pl | 12 ++++++------ > .../prog/en/modules/acqui/addorderiso2709.tt | 2 +- > 2 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl >index c34393e..23292da 100755 >--- a/acqui/addorderiso2709.pl >+++ b/acqui/addorderiso2709.pl >@@ -356,7 +356,7 @@ sub import_batches_list { > if (scalar @$stagedList) { > push @list, { > import_batch_id => $batch->{'import_batch_id'}, >- num_biblios => $batch->{'num_biblios'}, >+ num_records => $batch->{'num_records'}, > num_items => $batch->{'num_items'}, > staged_date => $batch->{'upload_timestamp'}, > import_status => $batch->{'import_status'}, >@@ -426,12 +426,12 @@ sub import_biblios_list { > > push @list, \%cellrecord; > } >- my $num_biblios = $batch->{'num_biblios'}; >+ my $num_records = $batch->{'num_records'}; > my $overlay_action = GetImportBatchOverlayAction($import_batch_id); > my $nomatch_action = GetImportBatchNoMatchAction($import_batch_id); > my $item_action = GetImportBatchItemAction($import_batch_id); > $template->param(biblio_list => \@list, >- num_results => $num_biblios, >+ num_results => $num_records, > import_batch_id => $import_batch_id, > "overlay_action_${overlay_action}" => 1, > overlay_action => $overlay_action, >@@ -450,9 +450,9 @@ sub batch_info { > comments => $batch->{'comments'}, > import_status => $batch->{'import_status'}, > upload_timestamp => $batch->{'upload_timestamp'}, >- num_biblios => $batch->{'num_biblios'}, >- num_items => $batch->{'num_biblios'}); >- if ($batch->{'num_biblios'} > 0) { >+ num_records => $batch->{'num_records'}, >+ num_items => $batch->{'num_records'}); >+ if ($batch->{'num_records'} > 0) { > if ($batch->{'import_status'} eq 'staged' or $batch->{'import_status'} eq 'reverted') { > $template->param(can_commit => 1); > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >index acede4e..528acc6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >@@ -396,7 +396,7 @@ > [% END %] > </td> > <td><span title="[% batch_lis.staged_date %]">[% batch_lis.staged_date | $KohaDates with_hours => 1 %]</span></td> >- <td>[% batch_lis.num_biblios %]</td> >+ <td>[% batch_lis.num_records %]</td> > <td><a href="[% batch_lis.scriptname %]?import_batch_id=[% batch_lis.import_batch_id %]&basketno=[% basketno %]&booksellerid=[% booksellerid %]">Add orders</a></td> > </tr> > [% END %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9063
:
13409
|
27132
|
27264
|
27326
|
27957