Bugzilla – Attachment 28331 Details for
Bug 12288
Search Errors with AggressiveMatchOnISBN turned on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 12288 - Search Errors with AggressiveMatchOnISBN turned on
SIGNED-OFF-Bug-12288---Search-Errors-with-Aggressi.patch (text/plain), 1.52 KB, created by
Martin Renvoize (ashimema)
on 2014-05-19 13:30:58 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 12288 - Search Errors with AggressiveMatchOnISBN turned on
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2014-05-19 13:30:58 UTC
Size:
1.52 KB
patch
obsolete
>From 96ac0aa23750419d028e56eb1321380da5b3e85a Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 19 May 2014 08:37:28 -0400 >Subject: [PATCH] [SIGNED OFF] Bug 12288 - Search Errors with > AggressiveMatchOnISBN turned on > >I'm seeing a number of search errors, as follows, in the logs when >running a stage import with the AggressiveMatchOnISBN syspref turned on. > >search failed (isbn,phr=978-0-7517-9745-9 or isbn,phr=0-7517-9745-6 or >isbn,phr=978-0-7517-9745-9 or isbn,phr=0751797456 or >isbn,phr=9780751797459 or isbn,phr=978-0-7517-9759-6 or >isbn,phr=0-7517-9759-6 or isbn,phr=978-0-7517-9759-6 or >isbn,phr=0751797596 or isbn,phr=9780751797596 or isbn,phr= or >isbn,phr= or isbn,phr= or isbn,phr= or isbn,phr=) CCL parsing >error (10014) Search word expected ZOOM at >/usr/share/koha/lib/C4/Matcher.pm line 688. > >This is most easily seen when running the script from command line >/misc/stage_file.pl. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Koha.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 5988249..139abfb 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -1640,6 +1640,9 @@ sub GetVariationsOfISBN { > push( @isbns, NormalizeISBN({ isbn => $isbn, format => 'ISBN-10', strip_hyphens => 1 }) ); > push( @isbns, NormalizeISBN({ isbn => $isbn, format => 'ISBN-13', strip_hyphens => 1 }) ); > >+ # Strip out any "empty" strings from the array >+ @isbns = grep { /\S/ } @isbns; >+ > return wantarray ? @isbns : join( " | ", @isbns ); > } > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12288
:
28329
| 28331