Bug 12288 - Search Errors with AggressiveMatchOnISBN turned on
Summary: Search Errors with AggressiveMatchOnISBN turned on
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-19 12:34 UTC by Martin Renvoize
Modified: 2014-12-07 20:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12288 - Search Errors with AggressiveMatchOnISBN turned on (1.46 KB, patch)
2014-05-19 12:38 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12288 - Search Errors with AggressiveMatchOnISBN turned on (1.52 KB, patch)
2014-05-19 13:30 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2014-05-19 12:34:11 UTC
I'm seeing a number of search errors, as follows, in the logs when running a stage import with the AggressiveMatchOnISBN syspref turned on.

search failed (isbn,phr=978-0-7517-9745-9 or isbn,phr=0-7517-9745-6 or isbn,phr=978-0-7517-9745-9 or isbn,phr=0751797456 or isbn,phr=9780751797459 or isbn,phr=978-0-7517-9759-6 or isbn,phr=0-7517-9759-6 or isbn,phr=978-0-7517-9759-6 or isbn,phr=0751797596 or isbn,phr=9780751797596 or isbn,phr= or isbn,phr= or isbn,phr= or isbn,phr= or isbn,phr=) CCL parsing error (10014) Search word expected ZOOM at /usr/share/koha/lib/C4/Matcher.pm line 688.

This is most easily seen when running the script from command line /misc/stage_file.pl.
Comment 1 Kyle M Hall 2014-05-19 12:38:33 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2014-05-19 13:30:58 UTC
Created attachment 28331 [details] [review]
[SIGNED OFF] Bug 12288 - Search Errors with AggressiveMatchOnISBN turned on

I'm seeing a number of search errors, as follows, in the logs when
running a stage import with the AggressiveMatchOnISBN syspref turned on.

search failed (isbn,phr=978-0-7517-9745-9 or isbn,phr=0-7517-9745-6 or
isbn,phr=978-0-7517-9745-9 or isbn,phr=0751797456 or
isbn,phr=9780751797459 or isbn,phr=978-0-7517-9759-6 or
isbn,phr=0-7517-9759-6 or isbn,phr=978-0-7517-9759-6 or
isbn,phr=0751797596 or isbn,phr=9780751797596 or isbn,phr= or
isbn,phr= or isbn,phr= or isbn,phr= or isbn,phr=) CCL parsing
error (10014) Search word expected ZOOM at
/usr/share/koha/lib/C4/Matcher.pm line 688.

This is most easily seen when running the script from command line
/misc/stage_file.pl.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2014-05-19 13:31:50 UTC
This minor change squelches the errors and doesn't cause any regressions.

Thanks Kyle
Comment 4 Galen Charlton 2014-05-19 20:04:14 UTC
I've taken the liberty of passing QA on this and pushing to master (along with a regression test).  Thanks, Kyle!