Attachment 29135 Details for Bug 12419 – [PASSED QA] Bug 12419: Not for loan items are not listed

[patch] [PASSED QA] Bug 12419: Not for loan items are not listed

PASSED-QA-Bug-12419-Not-for-loan-items-are-not-lis.patch (text/plain), 3.87 KB, created by Katrin Fischer on 2014-06-21 16:40:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-06-21 16:40:12 UTC

Size: 3.87 KB

patch

obsolete

>From 3f644833d30c59f759f505002c432f25cbdbd831 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Fri, 13 Jun 2014 15:27:45 +0200
>Subject: [PATCH] [PASSED QA] Bug 12419: Not for loan items are not listed
>
>On the cataloguing search (cataloguing/addbook.pl), if an item has a
>notforloan value > 0, the item is not listed in the Location column.
>
>It is quite confusing, the current behavior let patrons believe that
>there is not item for the biblio (or less than the real count).
>
>Test plan:
>1/ Create 2 biblio records A and B
>2/ Create some items for A
>3/ Create 1+ item(s) for B with a notforloan status > 0
>4/ Reindex both records
>5/ Launch a search on the cataloguing module and verify that the
>notforloan items are not listed in the 'Location' column.
>6/ Apply this patch and verify the not for loan items are listed ("Not
>for loan (XXX)").
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Passes tests and QA script, not for loan items now show up.
>---
> C4/Search.pm | 4 ++++
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 3 ++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Search.pm b/C4/Search.pm
>index 748bb1c..5ac54c3 100644
>--- a/C4/Search.pm
>+++ b/C4/Search.pm
>@@ -1856,6 +1856,7 @@ sub searchResults {
> my $item_in_transit_count = 0;
> my $can_place_holds = 0;
> my $item_onhold_count = 0;
>+ my $notforloan_count = 0;
> my $items_count = scalar(@fields);
> my $maxitems_pref = C4::Context->preference('maxItemsinSearchResults');
> my $maxitems = $maxitems_pref ? $maxitems_pref - 1 : 1;
>@@ -1926,6 +1927,8 @@ sub searchResults {
> # item is on order
> if ( $item->{notforloan} < 0 ) {
> $ordered_count++;
>+ } elsif ( $item->{notforloan} > 0 ) {
>+ $notforloan_count++;
> }
> 
> # is item in transit?
>@@ -2065,6 +2068,7 @@ sub searchResults {
> $oldbiblio->{intransitcount} = $item_in_transit_count;
> $oldbiblio->{onholdcount} = $item_onhold_count;
> $oldbiblio->{orderedcount} = $ordered_count;
>+ $oldbiblio->{notforloancount} = $notforloan_count;
> 
> if (C4::Context->preference("AlternateHoldingsField") && $items_count == 0) {
> my $fieldspec = C4::Context->preference("AlternateHoldingsField");
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>index 4f73372..4134cd3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
>@@ -144,7 +144,8 @@
> [% IF ( resultsloo.onloancount ) %] Checked out ([% resultsloo.onloancount %]), [% END %]
> [% IF ( resultsloo.withdrawncount ) %] Withdrawn ([% resultsloo.withdrawncount %]), [% END %]
> [% IF ( resultsloo.itemlostcount ) %] Lost ([% resultsloo.itemlostcount %]) [% END %]
>- [% IF ( resultsloo.orderedcount ) %] On order ([% resultsloo.orderedcount %])[% END %]
>+ [% IF ( resultsloo.orderedcount ) %] On order ([% resultsloo.orderedcount %]) [% END %]
>+ [% IF ( resultsloo.notforloancount ) %] Not for loan ([% resultsloo.notforloancount %])[% END %]
> 
> </td>
> 				<td> <a href="/cgi-bin/koha/catalogue/showmarc.pl?id=[% resultsloo.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">MARC</a> | <a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&amp;id=[% resultsloo.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">Card</a>
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 12419: 28838 | 28957 | 29135 | 29384 | 29385