Attachment 29193 Details for Bug 12465 – [SIGNED-OFF] Bug 12465: Improve display of MARC21 710 in intranet and OPAC

[patch] [SIGNED-OFF] Bug 12465: Improve display of MARC21 710 in intranet and OPAC

SIGNED-OFF-Bug-12465-Improve-display-of-MARC21-710.patch (text/plain), 7.65 KB, created by Bernardo Gonzalez Kriegel on 2014-06-24 14:53:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2014-06-24 14:53:25 UTC

Size: 7.65 KB

patch

obsolete

>From b36f61d50053c61608348ae2c011745f73613125 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Sun, 22 Jun 2014 19:31:50 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 12465: Improve display of MARC21 710 in
> intranet and OPAC
>
>Currently, 710$a and $b and $b will not display correctly.
>This patch tries to improve the display adding the missing
>space between both subfields.
>
>Please test.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Tested, work as described on staff & opac for 710 detailed view.
>Add space and punctuation.
>No errors.
>---
> .../prog/en/xslt/MARC21slim2intranetDetail.xsl     |   28 +++++++-------------
> .../prog/en/xslt/MARC21slim2intranetResults.xsl    |   23 +++++++---------
> .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |   28 +++++++-------------
> .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl   |   23 +++++++---------
> 4 files changed, 40 insertions(+), 62 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>index 3e7503a..003f528 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>@@ -848,24 +848,16 @@
>     </xsl:template>
> 
>     <xsl:template name="nameABCDN">
>-        <xsl:for-each select="marc:subfield[@code='a']">
>-                <xsl:call-template name="chopPunctuation">
>-                    <xsl:with-param name="chopString" select="."/>
>-                </xsl:call-template>
>-        </xsl:for-each>
>-        <xsl:for-each select="marc:subfield[@code='b']">
>-            <xsl:value-of select="."/>
>-            <xsl:choose>
>-                <xsl:when test="position() != last()">
>-                    <xsl:text> -- </xsl:text>
>-                </xsl:when>
>-            </xsl:choose>
>-        </xsl:for-each>
>-        <xsl:if test="marc:subfield[@code='c'] or marc:subfield[@code='d'] or marc:subfield[@code='n']">
>-                <xsl:call-template name="subfieldSelect">
>-                    <xsl:with-param name="codes">cdn</xsl:with-param>
>-                </xsl:call-template>
>-        </xsl:if>
>+            <xsl:call-template name="chopPunctuation">
>+                <xsl:with-param name="chopString">
>+                    <xsl:call-template name="subfieldSelect">
>+                        <xsl:with-param name="codes">abcdn</xsl:with-param>
>+                    </xsl:call-template>
>+                </xsl:with-param>
>+                <xsl:with-param name="punctuation">
>+                    <xsl:text>:,;/ </xsl:text>
>+                </xsl:with-param>
>+            </xsl:call-template>
>     </xsl:template>
> 
>     <xsl:template name="nameACDEQ">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
>index f3a1761..5391974 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
>@@ -881,19 +881,16 @@
>     </xsl:template>
> 
>     <xsl:template name="nameABCDN">
>-        <xsl:for-each select="marc:subfield[@code='a']">
>-                <xsl:call-template name="chopPunctuation">
>-                    <xsl:with-param name="chopString" select="."/>
>-                </xsl:call-template>
>-        </xsl:for-each>
>-        <xsl:for-each select="marc:subfield[@code='b']">
>-                <xsl:value-of select="."/>
>-        </xsl:for-each>
>-        <xsl:if test="marc:subfield[@code='c'] or marc:subfield[@code='d'] or marc:subfield[@code='n']">
>-                <xsl:call-template name="subfieldSelect">
>-                    <xsl:with-param name="codes">cdn</xsl:with-param>
>-                </xsl:call-template>
>-        </xsl:if>
>+            <xsl:call-template name="chopPunctuation">
>+                <xsl:with-param name="chopString">
>+                    <xsl:call-template name="subfieldSelect">
>+                        <xsl:with-param name="codes">abcdn</xsl:with-param>
>+                    </xsl:call-template>
>+                </xsl:with-param>
>+                <xsl:with-param name="punctuation">
>+                    <xsl:text>:,;/ </xsl:text>
>+                </xsl:with-param>
>+            </xsl:call-template>
>     </xsl:template>
> 
>     <xsl:template name="nameACDEQ">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index fdd5421..6e22599 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -1072,24 +1072,16 @@
>     </xsl:template>
> 
>     <xsl:template name="nameABCDN">
>-        <xsl:for-each select="marc:subfield[@code='a']">
>-                <xsl:call-template name="chopPunctuation">
>-                    <xsl:with-param name="chopString" select="."/>
>-                </xsl:call-template>
>-        </xsl:for-each>
>-        <xsl:for-each select="marc:subfield[@code='b']">
>-            <xsl:value-of select="."/>
>-            <xsl:choose>
>-                <xsl:when test="position() != last()">
>-                    <xsl:text> -- </xsl:text>
>-                </xsl:when>
>-            </xsl:choose>
>-        </xsl:for-each>
>-        <xsl:if test="marc:subfield[@code='c'] or marc:subfield[@code='d'] or marc:subfield[@code='n']">
>-                <xsl:call-template name="subfieldSelect">
>-                    <xsl:with-param name="codes">cdn</xsl:with-param>
>-                </xsl:call-template>
>-        </xsl:if>
>+            <xsl:call-template name="chopPunctuation">
>+                <xsl:with-param name="chopString">
>+                    <xsl:call-template name="subfieldSelect">
>+                        <xsl:with-param name="codes">abcdn</xsl:with-param>
>+                    </xsl:call-template>
>+                </xsl:with-param>
>+                <xsl:with-param name="punctuation">
>+                    <xsl:text>:,;/ </xsl:text>
>+                </xsl:with-param>
>+            </xsl:call-template>
>     </xsl:template>
> 
>     <xsl:template name="nameACDEQ">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>index ea6af38..62e01f9 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
>@@ -1196,19 +1196,16 @@
>     </xsl:template>
> 
>     <xsl:template name="nameABCDN">
>-        <xsl:for-each select="marc:subfield[@code='a']">
>-                <xsl:call-template name="chopPunctuation">
>-                    <xsl:with-param name="chopString" select="."/>
>-                </xsl:call-template>
>-        </xsl:for-each>
>-        <xsl:for-each select="marc:subfield[@code='b']">
>-                <xsl:value-of select="."/>
>-        </xsl:for-each>
>-        <xsl:if test="marc:subfield[@code='c'] or marc:subfield[@code='d'] or marc:subfield[@code='n']">
>-                <xsl:call-template name="subfieldSelect">
>-                    <xsl:with-param name="codes">cdn</xsl:with-param>
>-                </xsl:call-template>
>-        </xsl:if>
>+            <xsl:call-template name="chopPunctuation">
>+                <xsl:with-param name="chopString">
>+                    <xsl:call-template name="subfieldSelect">
>+                        <xsl:with-param name="codes">abcdn</xsl:with-param>
>+                    </xsl:call-template>
>+                </xsl:with-param>
>+                <xsl:with-param name="punctuation">
>+                    <xsl:text>:,;/ </xsl:text>
>+                </xsl:with-param>
>+            </xsl:call-template>
>     </xsl:template>
> 
>     <xsl:template name="nameACDEQ">
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 12465: 29145 | 29146 | 29193 | 30391