If you have a record with 710$a and $b, there is no space or punctuation between the fields in result list and detail page in OPAC and staff.
Example: 710 2 _aDeutschland _bBundestag _0(DE-588b)2116123-9 _0(DE-576)193731266 _9167
Created attachment 29145 [details] [review] Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test.
I am not sure if the attached patch fixes all cases and is ok as it is. Feedback very welcome!
Created attachment 29146 [details] [review] Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test.
Created attachment 29193 [details] [review] [SIGNED-OFF] Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested, work as described on staff & opac for 710 detailed view. Add space and punctuation. No errors.
QA: Taking a look :)
Created attachment 30391 [details] [review] Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested, work as described on staff & opac for 710 detailed view. Add space and punctuation. No errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: This patch improves the situation. Before $a and $b were glued together. Now we have a space in between everywhere for subfields a-b-c-d-n. I am not saying that we already reached the ideal solution. Just listing multiple $b's after $a with a space (and even more subfields possible) may probably not always be so clear. But I do not have "the better solution" at hand for this moment :) Passed QA
Thx Marcel!
*** Bug 10957 has been marked as a duplicate of this bug. ***
I'm not sure about the result. I prefered my approach on the other bug. But this is a good start. Maybe later someone will make it even better.
I am sorry to have missed your bug - it wasn't intentional. :( I kept it rather simple, because I was not totally sure either. Feedback from a cataloguing expert might be good :)
We agreed the patch needs to be revisited as it chomps any punctuation added by the cataloguer.
Hi Tomas, for testing purposes I have cataloged the examples for 710 (from the German MARC21 translation, but they should be the same as on the LOC website, which is currently down for maintenance, these are the results: Examples: $aMinnesota. $bConstitutional Convention $d(1857 : $gRepublican) $aHerbert E. Budek Films and Slides (Firm) $aUnited States. $bArmy Map Service. $tEastern United States 1:250,000. $aNew Orleans Blue Serenaders. $4prf $aWGBH (Television station : Boston, Mass.) $aHallmark Collection (Library of Congress) $5DLC $aBridgewater Library, $eformer owner. $5NjP $a Algeria. $t Treaties, etc. $g England and Wales, $d 1682 Apr. 20. $a Catholic Church. $t Mass, 33rd Sunday of ordinary time (Chant). $f 1979. $a Catholic Church. $b Pope (1958-1963 : John XXIII). $t Mater et magistra. $l French. $k Selections. $f 1963. $a United States. $t Constitution. $p 13th Amendment. $a Ecuador. $t Plan Nacional de Desarrollo, 1980-1984. $n Parte 1, $p Grandes objetivos nacionales. $l English. With the existing patch: Minnesota. Constitutional Convention (1857; United States. Army Map Service; New Orleans Blue Serenaders [prf]; WGBH (Television station : Boston, Mass.); Hallmark Collection (Library of Congress); Bridgewater Library [former owner.]; Algeria. 1682 Apr. 20; Catholic Church; Catholic Church Pope ( 1958-1963 : John XXIII); United States; Ecuador. Parte 1. Displaying 'as catalogued': by Herbert E. Budek Films and Slides (Firm); Minnesota. Constitutional Convention (1857:; United States. Army Map Service.; New Orleans Blue Serenaders [prf]; WGBH (Television station : Boston, Mass.); Hallmark Collection (Library of Congress); Bridgewater Library, [former owner.]; Algeria. 1682 Apr. 20.; Catholic Church.; Catholic Church Pope ( 1958-1963 : John XXIII).; United States.; Ecuador. Parte 1,. What we can see: - we are not displaying all subfields currently that could be used - the patch is just chopping off punctuation off the last subfield, which seems ok, since we are using semicolons between every 710. Could you take another look?
Patch pushed to master. Thanks Katrina!
Pushed to 3.16.x for inclusion in 3.16.4.