Attachment 29964 Details for Bug 8474 – Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem

[patch] Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem

Bug-8474---Holds-done-by-librarians-cause-silent-e.patch (text/plain), 1.25 KB, created by Olli-Antti Kivilahti on 2014-07-23 08:17:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olli-Antti Kivilahti

Created: 2014-07-23 08:17:08 UTC

Size: 1.25 KB

patch

obsolete

>From a0225f3f1885411ce7c22f19a25dd4bf7b587536 Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Wed, 23 Jul 2014 11:15:57 +0300
>Subject: [PATCH] Bug 8474 - Holds done by librarians cause silent errors in
> koha-error_log, placerequest.pl -> $checkitem
>
>Squashed this rogue variable initialization
>---
> reserve/placerequest.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl
>index 3fe459c..d47b913 100755
>--- a/reserve/placerequest.pl
>+++ b/reserve/placerequest.pl
>@@ -72,7 +72,7 @@ my $found;
> 
> # if we have an item selectionned, and the pickup branch is the same as the holdingbranch
> # of the document, we force the value $rank and $found .
>-if ($checkitem ne ''){
>+if (defined $checkitem && $checkitem ne ''){
>     $rank[0] = '0' unless C4::Context->preference('ReservesNeedReturns');
>     my $item = $checkitem;
>     $item = GetItem($item);
>@@ -98,7 +98,7 @@ if ($type eq 'str8' && $borrower){
>         }
>         my $const;
> 
>-	if ($checkitem ne ''){
>+	if (defined $checkitem && $checkitem ne ''){
> 		my $item = GetItem($checkitem);
>         	if ($item->{'biblionumber'} ne $biblionumber) {
>                 	$biblionumber = $item->{'biblionumber'};
>-- 
>1.8.1.2

Actions: View | Diff | Splinter Review

Attachments on bug 8474: 11000 | 29964 | 37715 | 37932