Attachment 31573 Details for Bug 12841 – sign-off for patch

[patch] sign-off for patch

0001-Bug-12841-aqorders-fields-should-not-be-mapped.patch (text/plain), 1.97 KB, created by Zeno Tajoli on 2014-09-13 10:13:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Zeno Tajoli

Created: 2014-09-13 10:13:08 UTC

Size: 1.97 KB

patch

obsolete

>From 7c757d5157e6b5c1bc2b51004422b7bd1abbd28a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 26 Aug 2014 10:50:22 +0200
>Subject: [PATCH] Bug 12841: aqorders fields should not be mapped
>
>Bug 5336 introduced some code which should have been introduced by bug
>7294.
>Since the idea behind bug 7294 has been abandoned (map the aqorders
>fields), the code can be removed.
>
>Test plan:
>Verify that Koha does not allow you to map the aqorders fields with a
>MARC subfield.
>Verify there is no regression on adding/updating an order.
>
>Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
>---
> acqui/addorder.pl |    7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/acqui/addorder.pl b/acqui/addorder.pl
>index e048d05..709b393 100755
>--- a/acqui/addorder.pl
>+++ b/acqui/addorder.pl
>@@ -250,13 +250,6 @@ if ( $orderinfo->{quantity} ne '0' ) {
>                 "biblio.copyrightdate"        => $$orderinfo{publicationyear} ? $$orderinfo{publicationyear}: "",
>                 "biblioitems.itemtype"        => $$orderinfo{itemtype} ? $$orderinfo{itemtype} : "",
>                 "biblioitems.editionstatement"=> $$orderinfo{editionstatement} ? $$orderinfo{editionstatement} : "",
>-                "aqorders.branchcode"         => $$orderinfo{branchcode} ? $$orderinfo{branchcode} : "",
>-                "aqorders.quantity"           => $$orderinfo{quantity} ? $$orderinfo{quantity} : "",
>-                "aqorders.listprice"          => $$orderinfo{listprice} ? $$orderinfo{listprice} : "",
>-                "aqorders.uncertainprice"     => $$orderinfo{uncertainprice} ? $$orderinfo{uncertainprice} : "",
>-                "aqorders.rrp"                => $$orderinfo{rrp} ? $$orderinfo{rrp} : "",
>-                "aqorders.ecost"              => $$orderinfo{ecost} ? $$orderinfo{ecost} : "",
>-                "aqorders.discount"           => $$orderinfo{discount} ? $$orderinfo{discount} : "",
>             });
> 
>         # create the record in catalogue, with framework ''
>-- 
>1.7.10.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 12841: 31245 | 31573 | 31576 | 31737