Bugzilla – Attachment 31740 Details for
Bug 12839
aqbooksellers.gstreg is never used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12839: aqbooksellers.gstreg is never used
PASSED-QA-Bug-12839-aqbooksellersgstreg-is-never-u.patch (text/plain), 3.18 KB, created by
Kyle M Hall (khall)
on 2014-09-19 12:44:06 UTC
(
hide
)
Description:
[PASSED QA] Bug 12839: aqbooksellers.gstreg is never used
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-09-19 12:44:06 UTC
Size:
3.18 KB
patch
obsolete
>From 5921deedf081b19cd05e1373f5fc7eb24ad8719c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 26 Aug 2014 12:46:52 +0200 >Subject: [PATCH] [PASSED QA] Bug 12839: aqbooksellers.gstreg is never used > >The aqbooksellers.gstreg is never used in the code. >This patch does not remove the DB field but 3 useless occurrences in the >neworderempty page. > >The both variable applygst and gstreg have never been took into account for prices calculation. > >Test plan: >Verify there is no difference before and after the patch in the prices >calculation. > >Signed-off-by: Paola Rossi <paola.rossi@cineca.it> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > acqui/neworderempty.pl | 1 - > koha-tmpl/intranet-tmpl/prog/en/js/acq.js | 1 - > .../prog/en/modules/acqui/neworderempty.tt | 1 - > 3 files changed, 0 insertions(+), 3 deletions(-) > >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index 256175a..69a194a 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -390,7 +390,6 @@ $template->param( > rrp => $data->{'rrp'}, > gst_values => \@gst_values, > gstrate => $data->{gstrate} ? $data->{gstrate}+0.0 : $bookseller->{gstrate} ? $bookseller->{gstrate}+0.0 : 0, >- gstreg => $bookseller->{'gstreg'}, > listprice => sprintf( "%.2f", $data->{listprice} || $data->{price} || $listprice), > total => sprintf( "%.2f", ($data->{ecost} || 0) * ($data->{'quantity'} || 0) ), > ecost => sprintf( "%.2f", $data->{ecost} || 0), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/acq.js b/koha-tmpl/intranet-tmpl/prog/en/js/acq.js >index 3bac18b..ddd95bc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/acq.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/acq.js >@@ -178,7 +178,6 @@ function messenger(X,Y,etc){ // FIXME: unused? > function updateCosts(){ > var quantity = new Number($("#quantity").val()); > var discount = new Number($("#discount").val()); >- var applygst = new Number ($("#applygst").val()); > var listprice = new Number($("#listprice").val()); > var currcode = new String($("#currency").val()); > var exchangerate = new Number($("#currency_rate_"+currcode).val()); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index 64ad028..00027b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -242,7 +242,6 @@ $(document).ready(function() > <input type="hidden" name="booksellerid" value="[% booksellerid %]" /> > <input type="hidden" name="biblionumber" value="[% biblionumber %]" /> > <input type="hidden" name="listinc" id="listinc" value="[% listincgst %]" /> >- <input type="hidden" name="applygst" id="applygst" value="[% gstreg %]" /> > <input type="hidden" name="invoiceincgst" id="invoiceincgst" value="[% invoiceincgst %]" /> > <input type="hidden" name="suggestionid" value="[% suggestionid %]" /> > <input type="hidden" name="import_batch_id" value="[% import_batch_id %]" /> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12839
:
31239
|
31493
| 31740