Created attachment 31239 [details] [review] Bug 12839: aqbooksellers.gstreg is never used The aqbooksellers.gstreg is never used in the code. This patch does not remove the DB field but 3 useless occurrences in the neworderempty page. The both variable applygst and gstreg have never been took into account for prices calculation. Test plan: Verify there is no difference before and after the patch in the prices calculation.
Created attachment 31493 [details] [review] Bug 12839: aqbooksellers.gstreg is never used I've applied against master 3.17.00.023 Everything's OK. So I pass the patch to "Signed Off" status.
Created attachment 31740 [details] [review] [PASSED QA] Bug 12839: aqbooksellers.gstreg is never used The aqbooksellers.gstreg is never used in the code. This patch does not remove the DB field but 3 useless occurrences in the neworderempty page. The both variable applygst and gstreg have never been took into account for prices calculation. Test plan: Verify there is no difference before and after the patch in the prices calculation. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.01