Attachment 32571 Details for Bug 13108 – [PASSED QA] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve

[patch] [PASSED QA] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve

PASSED-QA-Bug-13108---Members-are-restricted-even-.patch (text/plain), 1.73 KB, created by Katrin Fischer on 2014-10-21 22:36:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-10-21 22:36:18 UTC

Size: 1.73 KB

patch

obsolete

>From 6915da3d9ce895bd80d40d8ae0b41c764a9b67c7 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Fri, 17 Oct 2014 18:37:56 +0200
>Subject: [PATCH] [PASSED QA] Bug 13108 - Members are restricted even if the
> debarment is ended - opac-reserve
>
>This is the same issue as bug 12134.
>
>Test Plan:
>1) Add a manual restriction to a patron with expiration date in the past
>2) Go on the OPAC and connect
>3) Try to add an hold on a record (opac-reserve.pl)
>3) Note the warning message
>    "Sorry, you cannot place holds because your account has been frozen ..."
>4) Apply this patch
>5) Repeat step 2
>6) Note the warning message does not appear anymore
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Makes code cleaner, also works as described.
>
>NOTE: If you set a debarment with date in the past in the GUI,
>there will be no entry in borrowers.debarred and you won't be
>able to see the problem. Set one with a date in the future and
>then alter the date in borrower_debarments and borrowers.debarred.
>---
> opac/opac-reserve.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index 45d03bd..2875036 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -35,6 +35,7 @@ use C4::Branch; # GetBranches
> use C4::Overdues;
> use C4::Debug;
> use Koha::DateUtils;
>+use Koha::Borrower::Debarments qw(IsDebarred);
> use Date::Calc qw/Today Date_to_Days/;
> # use Data::Dumper;
> 
>@@ -320,7 +321,7 @@ if ( $borr->{lost} && ($borr->{lost} == 1) ) {
>         lost    => 1
>     );
> }
>-if ( $borr->{'debarred'} ) {
>+if ( IsDebarred($borrowernumber) ) {
>     $noreserves = 1;
>     $template->param(
>         message  => 1,
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13108: 32518 | 32523 | 32571