Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve
Summary: Members are restricted even if the debarment is ended - opac-reserve
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 12134
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-17 16:36 UTC by Fridolin Somers
Modified: 2015-06-04 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve (1.31 KB, patch)
2014-10-17 16:40 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve (1.37 KB, patch)
2014-10-19 19:07 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve (1.73 KB, patch)
2014-10-21 22:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2014-10-17 16:36:02 UTC
Same issue as bug 12134 on the opac/opac-reserve.pl
Comment 1 Fridolin Somers 2014-10-17 16:40:49 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-19 19:07:26 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-21 22:36:18 UTC
Created attachment 32571 [details] [review]
[PASSED QA] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve

This is the same issue as bug 12134.

Test Plan:
1) Add a manual restriction to a patron with expiration date in the past
2) Go on the OPAC and connect
3) Try to add an hold on a record (opac-reserve.pl)
3) Note the warning message
    "Sorry, you cannot place holds because your account has been frozen ..."
4) Apply this patch
5) Repeat step 2
6) Note the warning message does not appear anymore

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Makes code cleaner, also works as described.

NOTE: If you set a debarment with date in the past in the GUI,
there will be no entry in borrowers.debarred and you won't be
able to see the problem. Set one with a date in the future and
then alter the date in borrower_debarments and borrowers.debarred.
Comment 4 Tomás Cohen Arazi 2014-11-19 16:36:56 UTC
Patch pushed to master.

Thanks Fridolin!