Bugzilla – Attachment 32851 Details for
Bug 12302
OPAC course details not displaying item status correctly for itemtypes that are not for loan
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan
Bug-12302---OPAC-course-details-not-displaying-ite.patch (text/plain), 1.96 KB, created by
Frédéric Demians
on 2014-10-28 18:14:05 UTC
(
hide
)
Description:
Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2014-10-28 18:14:05 UTC
Size:
1.96 KB
patch
obsolete
>From 0df8287a3f82429cc93bb8e38097bbe480da17ed Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 21 May 2014 08:05:53 -0400 >Subject: [PATCH] Bug 12302 - OPAC course details not displaying item status > correctly for itemtypes that are not for loan > >If an item is not for loan based on it's itemtype, >opac-detail.pl will show the item as "Not for loan" >but opac-course-details.pl will show the item as "Available". > >Test Plan: >1) Enable course reserves >2) Create a course, add an item to it >3) Edit that item's itemtype, set it to not for loan >4) View the item from opac-detail.pl, note the status is "Not for loan" >5) View the item from opac-course-details.pl, note the status is "Available" >6) Apply this patch >7) Reload opac-course-details.pl, not the status is now "Not for loan" > >Signed-off-by: Frederic Demians <f.demians@tamil.fr> > >This is a revised version of the patch, introducing a invalid display on item >table (see obsolete bug 13155). It works, and correct the bug described by >Kyle. A 2nd sign-off may be necessrary. >--- > C4/Biblio.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index ec4c71e..3a93e90 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -893,10 +893,12 @@ sub GetBiblioFromItemNumber { > my $sth; > if ($itemnumber) { > $sth = $dbh->prepare( >- "SELECT * FROM items >+ "SELECT items.*, biblio.*, biblioitems.*, itemtypes.notforloan as notforloan_per_itemtype FROM items > LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber > LEFT JOIN biblioitems ON biblioitems.biblioitemnumber = items.biblioitemnumber >- WHERE items.itemnumber = ?" >+ LEFT JOIN itemtypes ON itemtypes.itemtype = " . >+ (C4::Context->preference('item-level_itypes') ? 'items.itype' : 'biblioitems.itemtype') . >+ " WHERE items.itemnumber = ?" > ); > $sth->execute($itemnumber); > } else { >-- >2.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12302
:
28402
|
28403
|
32851
|
32852