If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available".
Created attachment 28402 [details] [review] Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is "Not for loan" 5) View the item from opac-course-details.pl, note the status is "Available" 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now "Not for loan"
Created attachment 28403 [details] [review] Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is "Not for loan" 5) View the item from opac-course-details.pl, note the status is "Available" 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now "Not for loan"
Hi Kyle, I tried testing, but after applying the patch I lose all info except availability and notes on opac-course-details.pl Item still shows as available as well
*** Bug 13155 has been marked as a duplicate of this bug. ***
Created attachment 32851 [details] [review] Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is "Not for loan" 5) View the item from opac-course-details.pl, note the status is "Available" 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now "Not for loan" Signed-off-by: Frederic Demians <f.demians@tamil.fr> This is a revised version of the patch, introducing a invalid display on item table (see obsolete bug 13155). It works, and correct the bug described by Kyle. A 2nd sign-off may be necessrary.
(In reply to Nick Clemens from comment #3) > Hi Kyle, > > I tried testing, but after applying the patch I lose all info except > availability and notes on opac-course-details.pl > > Item still shows as available as well Test the revised patch to confirm it works for you.
Created attachment 32852 [details] [review] [SIGNED OFF] Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available". Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is "Not for loan" 5) View the item from opac-course-details.pl, note the status is "Available" 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now "Not for loan" Signed-off-by: Frederic Demians <f.demians@tamil.fr> This is a revised version of the patch, introducing a invalid display on item table (see obsolete bug 13155). It works, and correct the bug described by Kyle. A 2nd sign-off may be necessrary. Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
This patch works, but I see 2 problems: - It only checks for the notforloan on the itemtype, but not for the notforloan in the item record itself. We should check both to match the behaviour on the result list and in other places. - The change in GetBiblioFromItemnumber should be backed up by unit tests. Failing for the second, but the first should be fixed here or separately to have a more complete fix.
We're seeing these issues with "Not for loan (Ordered)" statuses not displaying in the course reserves OPAC view. I've added comments to bugs #11979 and #13693. These all seem to be interrelated and trying to address the same problem.
*** Bug 11979 has been marked as a duplicate of this bug. ***
*** Bug 13693 has been marked as a duplicate of this bug. ***
I've found 2 duplicate bugs for this one... usually a good sign that this is annoying to quite a lot of people - Kyle or Nick, could we get a reworked patch for this?