Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan
Summary: OPAC course details not displaying item status correctly for itemtypes that a...
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
: 11979 13155 13693 (view as bug list)
Depends on:
Blocks: 13155
  Show dependency treegraph
 
Reported: 2014-05-21 12:05 UTC by Kyle M Hall
Modified: 2019-08-19 12:15 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan (1.70 KB, patch)
2014-05-21 12:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan (1.71 KB, patch)
2014-05-21 12:11 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan (1.96 KB, patch)
2014-10-28 18:14 UTC, Frédéric Demians
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan (2.03 KB, patch)
2014-10-28 18:47 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-05-21 12:05:42 UTC
If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as "Not for loan" but opac-course-details.pl will show the item as "Available".
Comment 1 Kyle M Hall 2014-05-21 12:10:05 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-05-21 12:11:25 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens 2014-09-04 00:57:27 UTC
Hi Kyle,

I tried testing, but after applying the patch I lose all info except availability and notes on opac-course-details.pl  

Item still shows as available as well
Comment 4 Frédéric Demians 2014-10-28 18:10:26 UTC
*** Bug 13155 has been marked as a duplicate of this bug. ***
Comment 5 Frédéric Demians 2014-10-28 18:14:05 UTC Comment hidden (obsolete)
Comment 6 Frédéric Demians 2014-10-28 18:15:10 UTC
(In reply to Nick Clemens from comment #3)
> Hi Kyle,
> 
> I tried testing, but after applying the patch I lose all info except
> availability and notes on opac-course-details.pl  
> 
> Item still shows as available as well

Test the revised patch to confirm it works for you.
Comment 7 Nick Clemens 2014-10-28 18:47:47 UTC
Created attachment 32852 [details] [review]
[SIGNED OFF] Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan

If an item is not for loan based on it's itemtype,
opac-detail.pl will show the item as "Not for loan"
but opac-course-details.pl will show the item as "Available".

Test Plan:
1) Enable course reserves
2) Create a course, add an item to it
3) Edit that item's itemtype, set it to not for loan
4) View the item from opac-detail.pl, note the status is "Not for loan"
5) View the item from opac-course-details.pl, note the status is "Available"
6) Apply this patch
7) Reload opac-course-details.pl, not the status is now "Not for loan"

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

This is a revised version of the patch, introducing a invalid display on item
table (see obsolete bug 13155). It works, and correct the bug described by
Kyle. A 2nd sign-off may be necessrary.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Comment 8 Katrin Fischer 2014-10-28 20:45:20 UTC
This patch works, but I see 2 problems:

- It only checks for the notforloan on the itemtype, but not for the notforloan in the item record itself. We should check both to match the behaviour on the result list and in other places.
- The change in GetBiblioFromItemnumber should be backed up by unit tests.

Failing for the second, but the first should be fixed here or separately to have a more complete fix.
Comment 9 Myka Kennedy Stephens 2019-08-02 14:06:44 UTC
We're seeing these issues with "Not for loan (Ordered)" statuses not displaying in the course reserves OPAC view. I've added comments to bugs #11979 and #13693. These all seem to be interrelated and trying to address the same problem.
Comment 10 Katrin Fischer 2019-08-18 20:48:19 UTC
*** Bug 11979 has been marked as a duplicate of this bug. ***
Comment 11 Katrin Fischer 2019-08-18 20:49:42 UTC
*** Bug 13693 has been marked as a duplicate of this bug. ***
Comment 12 Katrin Fischer 2019-08-18 20:51:33 UTC
I've found 2 duplicate bugs for this one... usually a good sign that this is annoying to quite a lot of people - Kyle or Nick, could we get a reworked patch for this?