Bugzilla – Attachment 33021 Details for
Bug 13168
"Today's checkouts" sort improperly because issuedate lacks seconds.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 13168 - "Today's checkouts" sort improperly because issuedate lacks seconds.
Signed-off-Bug-13168---Todays-checkouts-sort-impro.patch (text/plain), 1.61 KB, created by
Marc Véron
on 2014-10-31 05:28:53 UTC
(
hide
)
Description:
[Signed-off] Bug 13168 - "Today's checkouts" sort improperly because issuedate lacks seconds.
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-10-31 05:28:53 UTC
Size:
1.61 KB
patch
obsolete
>From adc7035a7212c2fc449f6775805af92d33ec22e1 Mon Sep 17 00:00:00 2001 >From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> >Date: Thu, 30 Oct 2014 14:57:09 +0200 >Subject: [PATCH] [Signed-off] Bug 13168 - "Today's checkouts" sort improperly > because issuedate lacks seconds. >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >TO REPLICATE: > >Prepare a bunch of Items (6+) for checking out, or have a set of barcodes ready for copy-pasting. >Check-out those items quickly within one minute and observe that the sorting order is not always from the first checkout to the last. > >This is because the issuedate doesn't have seconds defined. > >AFTER THIS > >The bunch of Items is sorted properly. > >Tiny patch, works as expected. Passed QA script. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > C4/Circulation.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 76b6652..c360a5a 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1276,8 +1276,8 @@ sub AddIssue { > $sth->execute( > $borrower->{'borrowernumber'}, # borrowernumber > $item->{'itemnumber'}, # itemnumber >- $issuedate->strftime('%Y-%m-%d %H:%M:00'), # issuedate >- $datedue->strftime('%Y-%m-%d %H:%M:00'), # date_due >+ $issuedate->strftime('%Y-%m-%d %H:%M:%S'), # issuedate >+ $datedue->strftime('%Y-%m-%d %H:%M:%S'), # date_due > C4::Context->userenv->{'branch'}, # branchcode > $auto_renew ? 1 : 0 # automatic renewal > ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13168
:
32970
|
33021
|
33082