Attachment 33545 Details for Bug 13253 – [PASSED QA] Bug 13253 - Unnecessary white space above checkouts table in circulation

[patch] [PASSED QA] Bug 13253 - Unnecessary white space above checkouts table in circulation

PASSED-QA-Bug-13253---Unnecessary-white-space-abov.patch (text/plain), 2.89 KB, created by Katrin Fischer on 2014-11-14 05:35:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-11-14 05:35:54 UTC

Size: 2.89 KB

patch

obsolete

>From bf5baf320dc22eb120c904125135536c38c3fd0e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 13 Nov 2014 20:15:22 -0500
>Subject: [PATCH] [PASSED QA] Bug 13253 - Unnecessary white space above
> checkouts table in circulation
>
>On the new checkouts page there is some padding above the checkouts,
>relatives' checkouts, and holds tables caused by extra markup in the
>table's sDom configuration (http://legacy.datatables.net/ref#sDom):
>
><'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t
>
>This creates several empty <div>s which don't serve any purpose. This
>patch simplifies it to:
>
>rt
>
>To test, apply the patch, clear your browser cache, and check out to a
>patron who has items checked out, holds on their account, and child
>records attached which also have checkouts.
>
>The padding above the table of checkouts, the table of relatives'
>checkouts, and the table of holds should match that on the sides.
>
>Signed-off-by: Liz Rea <liz@catalyst.net.nz>
>Checked per plan on both Check Out and Details pages, spacing appears correct.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works as described, no problems found.
>---
> koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/js/holds.js     | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>index e333776..ece3ff2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>@@ -156,7 +156,7 @@ $(document).ready(function() {
>                 "sEmptyTable" : MSG_DT_LOADING_RECORDS,
>             },
>             "bAutoWidth": false,
>-            "sDom": "<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t",
>+            "sDom": "rt",
>             "aoColumns": [
>                 {
>                     "mDataProp": function( oObj ) {
>@@ -398,7 +398,7 @@ $(document).ready(function() {
>         if ( ! relativesIssuesTable ) {
>             relativesIssuesTable = $("#relatives-issues-table").dataTable({
>                 "bAutoWidth": false,
>-                "sDom": "<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t",
>+                "sDom": "rt",
>                 "aaSorting": [],
>                 "aoColumns": [
>                     {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/holds.js b/koha-tmpl/intranet-tmpl/prog/en/js/holds.js
>index 73807ea..253f339 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/holds.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/holds.js
>@@ -5,7 +5,7 @@ $(document).ready(function() {
>         if ( ! holdsTable ) {
>             holdsTable = $("#holds-table").dataTable({
>                 "bAutoWidth": false,
>-                "sDom": "<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t",
>+                "sDom": "rt",
>                 "aoColumns": [
>                     {
>                         "mDataProp": "reservedate_formatted"
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13253: 33543 | 33544 | 33545