Attachment 33650 Details for Bug 12971 – Bug 12971 [QA Followup]

[patch] Bug 12971 [QA Followup]

Bug-12971-QA-Followup.patch (text/plain), 3.30 KB, created by Kyle M Hall (khall) on 2014-11-18 13:47:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-11-18 13:47:59 UTC

Size: 3.30 KB

patch

obsolete

>From d50c0e8646bfe1e4d0b7b094fcc1678104a76d16 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 18 Nov 2014 07:40:24 -0500
>Subject: [PATCH] Bug 12971 [QA Followup]
>
>* Makes the status column display "Overdue!" if overdue
>* Fixes the due date formatting
>* Sorts the checkouts by date due ( oldest to newest )
>  Note: I found no evidence that this data was previously sorted,
>  so I kept it simple. Sorting based on system preferences could
>  be a future enhancement.
>---
> .../prog/en/modules/members/moremember-print.tt    |   24 ++++++++++----------
> members/summary-print.pl                           |    3 ++
> 2 files changed, 15 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
>index e60a8e1..1d62a23 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
>@@ -41,20 +41,20 @@
>                     <th>Status</th>
>                 </tr>
> 
>-                [% FOREACH issueloo IN issues %]
>-                    [% IF ( issueloo.red ) %]<tr class="overdue">[% ELSE %]<tr>[% END %]
>+                [% FOREACH issue IN issues %]
>+                    [% IF ( issue.overdue ) %]<tr class="overdue">[% ELSE %]<tr>[% END %]
>                         <td>
>-                            [% issueloo.title |html %]
>-                            <a href="/cgi-bin/koha/catalogue/detail.pl?item=[% issueloo.itemnumber %]&amp;biblionumber=[% issueloo.biblionumber %]&amp;bi=[% issueloo.biblioitemnumber %]"></a>
>+                            [% issue.title |html %]
>+                            <a href="/cgi-bin/koha/catalogue/detail.pl?item=[% issue.itemnumber %]&amp;biblionumber=[% issue.biblionumber %]&amp;bi=[% issue.biblioitemnumber %]"></a>
>                         </td>
>-                        <td>[% issueloo.author %]</td>
>-                        <td>[% issueloo.itemcallnumber %]</td>
>-                        <td>[% issueloo.itemtype_description %]</td>
>-                        <td>[% issueloo.date_due %]</td>
>-                        <td>[% issueloo.barcode %]</td>
>-                        <td>[% issueloo.charge %]</td>
>-                        <td>[% issueloo.replacementprice %]</td>
>-                        <td>[% IF ( issueloo.red ) %]Overdue![% ELSE %]&nbsp;[% END %]</td>
>+                        <td>[% issue.author %]</td>
>+                        <td>[% issue.itemcallnumber %]</td>
>+                        <td>[% issue.itemtype_description %]</td>
>+                        <td>[% issue.date_due | $KohaDates %]</td>
>+                        <td>[% issue.barcode %]</td>
>+                        <td>[% issue.charge %]</td>
>+                        <td>[% issue.replacementprice %]</td>
>+                        <td>[% IF ( issue.overdue ) %]Overdue![% ELSE %]&nbsp;[% END %]</td>
>                     </tr>
>                 [% END %]
> 
>diff --git a/members/summary-print.pl b/members/summary-print.pl
>index ea227dd..208d2f9 100755
>--- a/members/summary-print.pl
>+++ b/members/summary-print.pl
>@@ -97,5 +97,8 @@ sub build_issue_data {
> 
>         push( @{$return}, \%row );
>     }
>+
>+    @{$return} = sort { $a->{date_due} <=> $b->{date_due} } @{$return};
>+
>     return $return;
> }
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 12971: 33621 | 33623 | 33625 | 33628 | 33650 | 33664 | 33665 | 33666 | 35484