Bug 12971 - Regression: Patron print summary doesn't show checkouts
Summary: Regression: Patron print summary doesn't show checkouts
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low critical (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
: 13034 (view as bug list)
Depends on: 11703
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-19 15:19 UTC by Rafal Kopaczka
Modified: 2019-06-27 09:24 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12971 - Regression: Patron print summary doesn't show checkouts (14.22 KB, patch)
2014-11-17 18:40 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12971 - Regression: Patron print summary doesn't show checkouts (13.73 KB, patch)
2014-11-17 18:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12971 - Regression: Patron print summary doesn't show checkouts (13.83 KB, patch)
2014-11-17 19:42 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 12971 - Regression: Patron print summary doesn't show checkouts (13.97 KB, patch)
2014-11-17 21:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12971 [QA Followup] (3.30 KB, patch)
2014-11-18 13:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12971 [QA Followup] - Fix error caused by patron not having any checkouts (788 bytes, patch)
2014-11-18 19:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12971 [QA Followup] (3.46 KB, patch)
2014-11-18 19:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12971 [QA Followup] - Fix error caused by patron not having any checkouts (956 bytes, patch)
2014-11-18 19:24 UTC, Owen Leonard
Details | Diff | Splinter Review
checkouts show in summary, 3.16.6 (72.00 KB, image/png)
2015-01-23 09:42 UTC, Mason James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafal Kopaczka 2014-09-19 15:19:18 UTC
Print summary page don't contains information about checked out and reserved items.
Bug 11703, made regression on "Print summary" option in member detail page. 
Originally moremember-print.tt uses data from moremember.pl sript (issueloop, reserveloop), which is no longer provided by it, but by ajax query. Without this loops, on print page are only borrower and fines/charges info. 

Also other templates (moremember-brief.tt & moremember-receipt.tt), responsible for printing members info, have data loops which was previously provided by moremember. But in cause of this two, it seems that they are no longer used anyway. As I investigated they are set up in moremember.pl:83-95, but on page use of this options is modified, to call printslip.pl not moremembers (in members-toolbar.inc). I could not find other places where they are used. 
Printslip however generate correct info, since it uses IssueSlip function.
Comment 1 Rafal Kopaczka 2014-10-09 12:02:22 UTC
*** Bug 13034 has been marked as a duplicate of this bug. ***
Comment 2 Kyle M Hall 2014-11-17 18:40:33 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-11-17 18:45:10 UTC
This submitted patch migrates the print function to a separate script and pares down the the data to only what is required for the template. This will keep moremember.pl from getting any more complex, and provides us with a focused patron printing feature. This will also be better in the long run for converting this template into a configurable slip.

Note, the template itself has much whitespace alteration to improve the readability of the template, but otherwise has remained largely unchanged. The only changes made were to take advantage of Koha's TT plugins to remove the need to pass some values from the script to the template.
Comment 4 Kyle M Hall 2014-11-17 18:58:24 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2014-11-17 19:42:42 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2014-11-17 19:45:13 UTC
I see one thing which has been missed, but it could be taken care of in a follow-up: Previously the table of checkouts indicated in the "Status" column whether the item is overdue. Now the status column is empty for all checkouts.

I notice a couple of other issues that would be nice to fix but which existed in 3.14.x:

- The date formatting is wrong "2013-08-21T23:59:00"
- The checkouts don't appear to have any relevant order. I would expect them to be ordered by due date -- perhaps according to the previousIssuesDefaultSortOrder system pref?
Comment 7 Katrin Fischer 2014-11-17 21:19:34 UTC
Created attachment 33628 [details] [review]
[PASSED QA] Bug 12971 - Regression: Patron print summary doesn't show checkouts

A patron's print summary should contain a list of checked out items
as it did in 3.16.2 and earlier.

Please note, as of 3.16.2 reserves were no longer part of the print
summary and thus are not part of this bug fixing patch.

Test Plan:
1) Find a patron with checked out items
2) Choose Print -> Print summary
3) Note the lack of a list of checkouts
4) Apply this patch
5) Reload the page
5) Print the summary again
6) Note the list of checkouts

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Works as described, apart from the missing status information
that Owen already noted on the bug.
Passes tests and QA script.
Comment 8 Katrin Fischer 2014-11-17 21:20:28 UTC
Kyle, please fix the problem Owen noted about the status not displaying in a follow-up, thx!
Comment 9 Kyle M Hall 2014-11-18 13:47:59 UTC Comment hidden (obsolete)
Comment 10 Owen Leonard 2014-11-18 15:26:17 UTC
The follow-up triggers an error if you try to print a summary for someone who has no checkouts.
Comment 11 Kyle M Hall 2014-11-18 19:10:15 UTC Comment hidden (obsolete)
Comment 12 Owen Leonard 2014-11-18 19:24:23 UTC
Created attachment 33665 [details] [review]
Bug 12971 [QA Followup]

* Makes the status column display "Overdue!" if overdue
* Fixes the due date formatting
* Sorts the checkouts by date due ( oldest to newest )
  Note: I found no evidence that this data was previously sorted,
  so I kept it simple. Sorting based on system preferences could
  be a future enhancement.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

This fixes the issues described for patrons with existing checkouts.
Comment 13 Owen Leonard 2014-11-18 19:24:28 UTC
Created attachment 33666 [details] [review]
Bug 12971 [QA Followup] - Fix error caused by patron not having any checkouts

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

This successfully fixes the problem observed when a patron has no
checkouts.
Comment 14 Tomás Cohen Arazi 2014-11-19 14:41:44 UTC
Patches pushed to master.

Thanks!
Comment 15 Liz Rea 2014-12-11 21:42:31 UTC
Will we be pulling this fix back to 3.16?

Cheers,
Liz
Comment 16 Mason James 2015-01-19 14:20:48 UTC
(In reply to Liz Rea from comment #15)
> Will we be pulling this fix back to 3.16?
> 
> Cheers,
> Liz

Pushed to 3.16.x, will be in 3.16.7
Comment 17 Mason James 2015-01-23 09:33:14 UTC
(In reply to Liz Rea from comment #15)
> Will we be pulling this fix back to 3.16?
> 
> Cheers,
> Liz

Hmm, I cant reproduce this bug in 3.16.6+ 
ie: the checkouts are showing OK from print-summary

you are hitting this bug in 3.16.x Liz?
Comment 18 Mason James 2015-01-23 09:42:13 UTC
Created attachment 35484 [details]
checkouts show in summary, 3.16.6
Comment 19 Liz Rea 2015-01-25 19:51:22 UTC
Comment on attachment 35484 [details]
checkouts show in summary, 3.16.6

Yes, we saw it, but it's been ages ago. Possibly it was fixed somewhere else.