Bugzilla – Attachment 33731 Details for
Bug 13305
Fix tab order in cataloguing/item editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13305: Fix tab order on three item editor forms
Bug-13305-Fix-tab-order-on-three-item-editor-forms.patch (text/plain), 5.38 KB, created by
Marcel de Rooy
on 2014-11-20 08:21:18 UTC
(
hide
)
Description:
Bug 13305: Fix tab order on three item editor forms
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-11-20 08:21:18 UTC
Size:
5.38 KB
patch
obsolete
>From b80d58a094afe49fd0e4f662fb946d9a7f0743ef Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 19 Nov 2014 16:55:27 +0100 >Subject: [PATCH] Bug 13305: Fix tab order on three item editor forms >Content-Type: text/plain; charset=utf-8 > >While working on bug 10480, I stumbled over the tab order on the forms >serials-edit, acqui/addorderiso2709 and services/itemrecorddisplay. They all >depend on C4::Items::PrepareItemrecordDisplay. > >Most of the inputs get a tabindex=1, but some don't. This creates a rather >weird tab order for keyboard users (like me). By adjusting one input from >C4::Items and the select in those three templates, the tab order is fixed. > >Test plan: >[1] Set system preference AcqCreateItem to "placing an order". >[2] Tab through the item fields on addorderiso2709. To do so, go to the > Acquisition module, open a basket and add an order from a staged file. > Click Add orders, go to Item information. >[3] Tab through items fields on services/itemrecorddisplay. You could do > this by creating a URL with biblionumber and itemnumber. But you can > also test it via Acquisition. The script additem.js calls this perl > script to create the item blocks on neworderempty. So again add an > order to a basket, but choose for "From a new empty record". >[4] Tab through item fields on serials-edit. Go to subscription detail. > Click Receive. Choose "Click to add item". (Note that this subscription > should create an item record when receiving this serial.) >--- > C4/Items.pm | 2 +- > .../prog/en/modules/acqui/addorderiso2709.tt | 2 +- > .../prog/en/modules/serials/serials-edit.tt | 2 +- > .../prog/en/modules/services/itemrecorddisplay.tt | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 62e89c8..be1ff49 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -3058,7 +3058,7 @@ sub PrepareItemrecordDisplay { > # oversize field (textarea) > $subfield_data{marc_value} = qq(<textarea tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="255">$defaultvalue</textarea>\n"); > } else { >- $subfield_data{marc_value} = "<input type=\"text\" name=\"field_value\" value=\"$defaultvalue\" size=\"50\" maxlength=\"255\" />"; >+ $subfield_data{marc_value} = "<input type=\"text\" tabindex=\"1\" name=\"field_value\" value=\"$defaultvalue\" size=\"50\" maxlength=\"255\" />"; > } > push( @loop_data, \%subfield_data ); > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >index cf03b7c..697f92d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >@@ -284,7 +284,7 @@ > [% END %] > > [% IF ( iteminformatio.marc_value.type == 'select' ) %] >- <select name="field_value" size="1"> >+ <select name="field_value" tabindex="1" size="1"> > [% FOREACH value IN iteminformatio.marc_value.values %] > [% IF ( value == iteminformatio.marc_value.default ) %] > <option value="[% value %]" selected="selected">[% iteminformatio.marc_value.labels.$value %]</option> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index 3877715..d812f11 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -265,7 +265,7 @@ $(document).ready(function() { > <label>[% iteminformatio.subfield %] - [% iteminformatio.marc_lib %]</label> > [% END %] > [% IF ( iteminformatio.marc_value.type == 'select' ) %] >- <select name="field_value" size="1"> >+ <select name="field_value" size="1" tabindex="1"> > [% FOREACH value IN iteminformatio.marc_value.values %] > [% IF ( value == iteminformatio.marc_value.default ) %] > <option value="[% value %]" selected="selected">[% iteminformatio.marc_value.labels.$value %]</option> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt >index d55268a..c8657b7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt >@@ -12,7 +12,7 @@ > <label>[% iteminfo.subfield %] - [% iteminfo.marc_lib %]</label> > [% END %] > [% IF ( iteminfo.marc_value.type == 'select' ) %] >- <select name="field_value" size="1"> >+ <select name="field_value" size="1" tabindex="1"> > [% FOREACH value IN iteminfo.marc_value.values %] > [% IF ( value == iteminfo.marc_value.default ) %] > <option value="[% value %]" selected="selected">[% iteminfo.marc_value.labels.$value %]</option> >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13305
:
33731
|
97650
|
98609
|
98613