Bugzilla – Attachment 34144 Details for
Bug 13375
Syspref search highlight styling broken in Chrome
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome
PASSED-QA-Bug-13375-Syspref-search-highlight-styli.patch (text/plain), 1.83 KB, created by
Kyle M Hall (khall)
on 2014-12-05 14:58:02 UTC
(
hide
)
Description:
[PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-12-05 14:58:02 UTC
Size:
1.83 KB
patch
obsolete
>From b466de8f17d9eba0cdf88be109540fbbf757e5b4 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 3 Dec 2014 08:36:04 -0500 >Subject: [PATCH] [PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome > >This patch encloses the the syspref description/values mix in a <div>. >It doesn't introduce any regression on other browsers (like Firefox) and >has the side effect to make Chrome render the highlighted words on >syspref searches well. > >This alternate patch uses a <div> instead of a <span> because it will >sometimes contain block-level elements. Follow the same plan: > >To test: >- Search for 'facet' on the sysprefs >=> FAIL: verify it has styling problems in Chrome >- Apply the patch, reload >=> SUCCESS: styling is correct > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/admin/preferences.tt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index dde4764..23befab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -110,7 +110,7 @@ > [% END %] > </code> > </td> >- <td> >+ <td><div> > [% FOREACH CHUNK IN LINE.CHUNKS %] > [% IF ( CHUNK.type_text ) %] > [% CHUNK.contents %] >@@ -166,7 +166,7 @@ > </dl> > [% END %] > [% END %] >- </td> >+ </div></td> > </tr> > [% IF ( loop.last ) %]</tbody></table>[% END %] > [% END %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13375
:
34075
|
34076
|
34077
|
34092
|
34093
| 34144