Bugzilla – Attachment 34378 Details for
Bug 13362
translate script creates dirs on update
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13362: translate script creates dirs on update
PASSED-QA-Bug-13362-translate-script-creates-dirs-.patch (text/plain), 1.56 KB, created by
Katrin Fischer
on 2014-12-14 20:10:08 UTC
(
hide
)
Description:
[PASSED QA] Bug 13362: translate script creates dirs on update
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-12-14 20:10:08 UTC
Size:
1.56 KB
patch
obsolete
>From a59f2bf614fe08acd372a2f0f34639d1eea97eea Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Fri, 28 Nov 2014 15:14:53 -0300 >Subject: [PATCH] [PASSED QA] Bug 13362: translate script creates dirs on > update > >A dir creation was uncommented (by me), the effect is >create a lang dir on 'update', which is no needed. > >To test: >1) Update translation files for a uninstalled language >(cd misc/translator; ./translate update xx-YY) > >2) Check new dirs >koha-tmpl/opac-tmpl/bootstrap/xx-YY/ >koha-tmpl/intranet-tmpl/prog/xx-YY/ >koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ > >3) Clean all >git clean -f -d > >4) Apply the patch > >5) Repeat 1) (i.e. update) > >6) Check no new dirs this time > >Signed-off-by: Frederic Demians <f.demians@tamil.fr> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Tested according to test plan, works as described. >Passes tests and QA script. >--- > misc/translator/LangInstaller.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/misc/translator/LangInstaller.pm b/misc/translator/LangInstaller.pm >index c538b57..b3b09da 100644 >--- a/misc/translator/LangInstaller.pm >+++ b/misc/translator/LangInstaller.pm >@@ -371,7 +371,6 @@ sub update_tmpl { > " To : $self->{path_po}/$self->{lang}$trans->{suffix}\n" > if $self->{verbose}; > my $lang_dir = "$trans->{dir}/$self->{lang}"; >- mkdir $lang_dir unless -d $lang_dir; > > my $trans_dir = ( $trans->{name} =~ /help/ )?"$trans->{dir}":"$trans->{dir}/en/"; > my $excludes = ( $trans->{name} =~ /UI/ )?"-x 'help'":""; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13362
:
34019
|
34020
| 34378