If you do "./translate update xx-YY', it creates an unnecessary dir 'xx-YY' on opac and staff themes
Created attachment 34019 [details] [review] Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time
Created attachment 34020 [details] [review] Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Created attachment 34378 [details] [review] [PASSED QA] Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan, works as described. Passes tests and QA script.
Patch pushed to master. Good catch Bernardo!
Pushed to 3.18.x will be in 3.18.2