Attachment 34430 Details for Bug 13430 – Bug 13430 - Simple version - Serial enumeration not visible when handling Serial Items. Circ- and member-modules.

[patch] Bug 13430 - Simple version - Serial enumeration not visible when handling Serial Items. Circ- and member-modules.

Bug-13430---Simple-version---Serial-enumeration-no.patch (text/plain), 4.50 KB, created by Olli-Antti Kivilahti on 2014-12-15 14:45:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olli-Antti Kivilahti

Created: 2014-12-15 14:45:08 UTC

Size: 4.50 KB

patch

obsolete

>From d6ceac2d4c93aa02e867c2f69e00e7f1b610728b Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Mon, 15 Dec 2014 16:38:47 +0200
>Subject: [PATCH] Bug 13430 - Simple version - Serial enumeration not visible
> when handling Serial Items. Circ- and member-modules.
>
>Adding enumchron (Vol info) to circ/circulation.pl and members/moremember.pl "Checkouts"-,
>"Relatives checkouts"- and "Holds"-views.
>
>TEST PREPARATIONS:
>-1. Find a Borrower/parent with a child/guarantee.
>-0. Make a Subscription (creating Items when receiving serial numbers) to a Biblio and receive atleast 4 numbers.
>
>TEST PLAN (HOLDS ENUMERATED):
>1. Make a reservation of two of the Serial Items for the Borrower and the Child, totaling 4 reservations.
>2. Check-in the reserved books to make sure an Item-level hold is in place and real Items match the reservations.
>3. Both the Borrower and Child have an enumchron (enumeration or chronology) after the title component of
>   the Item's title-column in their "Holds"-tab in circ/circulation.pl and members/moremember.pl
>
>TEST PLAN (CHECKOUTS ENUMERATED):
>4.  Make two arbitrary check-outs for the Parent and the Child.
>5.  In the "Checkouts"-tab, observe the two Items having an enumchron and two items without.
>6.  In the "Relatives' checkouts"-tab observe that the Child of the Parent and the Parent of the Child can see
>    the enumchrons on their relatives' loans.
>---
> koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js |    8 ++++++++
> koha-tmpl/intranet-tmpl/prog/en/js/holds.js     |    4 ++++
> svc/checkouts                                   |    2 ++
> svc/holds                                       |    1 +
> 4 files changed, 15 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>index a135496..741ca99 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
>@@ -218,6 +218,10 @@ $(document).ready(function() {
>                                   title += " " + value.subfield;
>                         });
> 
>+                        if ( oObj.enumchron ) {
>+                            title += " "+oObj.enumchron+" ";
>+                        }
>+
>                         title += "</a></span>";
> 
>                         if ( oObj.author ) {
>@@ -453,6 +457,10 @@ $(document).ready(function() {
>                                       title += " " + value.subfield;
>                             });
> 
>+                            if ( oObj.enumchron ) {
>+                                title += " "+oObj.enumchron+" ";
>+                            }
>+
>                             title += "</a></span>";
> 
>                             if ( oObj.author ) {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/holds.js b/koha-tmpl/intranet-tmpl/prog/en/js/holds.js
>index 60f747b..f187b2a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/holds.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/holds.js
>@@ -21,6 +21,10 @@ $(document).ready(function() {
>                                       title += " " + value.subfield;
>                             });
> 
>+                            if ( oObj.enumchron ) {
>+                                title += " "+oObj.enumchron+" ";
>+                            }
>+
>                             title += "</a>";
> 
>                             if ( oObj.author ) {
>diff --git a/svc/checkouts b/svc/checkouts
>index 51fd861..185381d 100755
>--- a/svc/checkouts
>+++ b/svc/checkouts
>@@ -76,6 +76,7 @@ my $sql = '
>         barcode,
>         itemnotes,
>         itemcallnumber,
>+        items.enumchron,
>         replacementprice,
> 
>         issues.branchcode,
>@@ -153,6 +154,7 @@ while ( my $c = $sth->fetchrow_hashref() ) {
>         branchcode => $c->{branchcode},
>         branchname => $c->{branchname},
>         itemcallnumber => $c->{itemcallnumber}   || q{},
>+        enumchron      => $c->{enumchron}        || q{},
>         charge         => $charge,
>         price          => $c->{replacementprice} || q{},
>         can_renew      => $can_renew,
>diff --git a/svc/holds b/svc/holds
>index 43bcf2a..f599b5d 100755
>--- a/svc/holds
>+++ b/svc/holds
>@@ -115,6 +115,7 @@ while ( my $h = $holds_rs->next() ) {
>         $hold->{barcode}        = $item->barcode();
>         $hold->{itemtype}       = $item->effective_itemtype();
>         $hold->{itemcallnumber} = $item->itemcallnumber() || q{};
>+        $hold->{enumchron} = $item->enumchron() || q{};
> 
>         my ( $transferred_when, $transferred_from, $transferred_to ) =
>           GetTransfers( $item->itemnumber() );
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 13430: 34280 | 34430