Our librarians need to know which enumerations of an Serial Item are on hold for a borrower and which are checked out. It is not enough to know just the title + author. This patch simply shows the koha.items.enumchron-field in the AJAX-driven checkout and holds-views and if no Items with enumchron are present, the column is automatically hidden.
Created attachment 34280 [details] [review] Bug 13430 - Serial enumeration not visible when handling Serial Items. Circ- and member-modules. Adding enumchron (Vol info) to circ/circulation.pl and members/moremember.pl. Making enumchron (Vol info)-column hide when it is not used. TEST PREPARATIONS: -1. Find a Borrower/parent with a child/guarantee. -0. Make a Subscription (creating Items when receiving serial numbers) to a Biblio and receive atleast 4 numbers. TEST PLAN (HOLDS ENUMERATED): 1. Make a reservation of two of the Serial Items for the Borrower and the Child, totaling 4 reservations. 2. Check-in the reserved books to make sure an Item-level hold is in place and real Items match the reservations. 3. Both the Borrower and Child have a "Vol info"-column with the Item enumchron (enumeration or chronology) in their "Holds"-tab in circ/circulation.pl and members/moremember.pl TEST PLAN (HOLDS UNENUMERATED): 4. Make two arbitrary reserves for both Parent and Child. 5. Observe that in the "Holds"-tab they have now two Items with enumchron and two without. 6. Check-out the reserved Items for the respective Parent/Child. 7. Observe that in the "Holds"-tab there is no "Vol info"-column. TEST PLAN (CHECKOUTS ENUMERATED): 8. Make two arbitrary check-outs for the Parent and the Child. 9. In the "Checkouts"-tab, observe the "Vol info"-column with two Items having an enumchron and two items without. 10. In the "Relatives' checkouts"-tab observe that the Child of the Parent and the Parent of the Child can see the "Vol info"-tab with their relatives' loans proper enumerations. TEST PLAN (CHECKOUTS UNENUMERATED): 11. Check-in the Serial Items for both the Parent and the Child. 12. Observe the missing "Vol info"-tab in the "Checkouts"-tab and in the "Relatives' checkouts"-tab.
Created attachment 34430 [details] [review] Bug 13430 - Simple version - Serial enumeration not visible when handling Serial Items. Circ- and member-modules. Adding enumchron (Vol info) to circ/circulation.pl and members/moremember.pl "Checkouts"-, "Relatives checkouts"- and "Holds"-views. TEST PREPARATIONS: -1. Find a Borrower/parent with a child/guarantee. -0. Make a Subscription (creating Items when receiving serial numbers) to a Biblio and receive atleast 4 numbers. TEST PLAN (HOLDS ENUMERATED): 1. Make a reservation of two of the Serial Items for the Borrower and the Child, totaling 4 reservations. 2. Check-in the reserved books to make sure an Item-level hold is in place and real Items match the reservations. 3. Both the Borrower and Child have an enumchron (enumeration or chronology) after the title component of the Item's title-column in their "Holds"-tab in circ/circulation.pl and members/moremember.pl TEST PLAN (CHECKOUTS ENUMERATED): 4. Make two arbitrary check-outs for the Parent and the Child. 5. In the "Checkouts"-tab, observe the two Items having an enumchron and two items without. 6. In the "Relatives' checkouts"-tab observe that the Child of the Parent and the Parent of the Child can see the enumchrons on their relatives' loans.
Added an alternative "Simple version" where no extra column is added like in the opac it is, but simply the enumchron is appended after the title. Use only the other version. not both! This is because the initial commit is not compatible with 3.16.4
I've applied the first patch against master 3.19.00.000 About this step: >TEST PLAN (HOLDS ENUMERATED): >1. Make a reservation of two of the Serial Items for the Borrower and the Child, totaling 4 reservations. I tried to place the second hold/reservation on a serial for the same "Borrower", but koha immediately warned me so: Cannot place hold Borrower already has a hold on this item and, after selecting the "Place hold" button, koha prevented me from placing the hold by the message: - This patron had already placed a hold on this item Please cancel the previous hold first I could not place 2 holds/reservations for a Borrower on the items of 1 serial ERROR, as required. So I pass the patch to "Failed QA" status.
It looks like I had missed a dependency there, and the dependency is quite a deep Koha modification allowing people to place multiple holds on one Biblio. We are rebasing all our production features against master when we upgrade to 3.22. We will upgrade when 3.22 comes out :)
Olli-Antti, any plan to fix this patch? Our first attemp at #14668 included changes you're making for this one. We cut them but are hoping this one goes through. Please let us know if you do not plan to move ahead. Thanks!