Bugzilla – Attachment 36128 Details for
Bug 13680
Items list on edit items page separates add items form from header and sidebar
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13680 - Items list on edit items page separates add items form from header and sidebar
Bug-13680---Items-list-on-edit-items-page-separate.patch (text/plain), 8.04 KB, created by
Brendan Gallagher
on 2015-02-24 04:55:38 UTC
(
hide
)
Description:
Bug 13680 - Items list on edit items page separates add items form from header and sidebar
Filename:
MIME Type:
Creator:
Brendan Gallagher
Created:
2015-02-24 04:55:38 UTC
Size:
8.04 KB
patch
obsolete
>From 66e9bd67fbde68a3990b66671a513a6ca0c5ec3e Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@quecheelibrary.org> >Date: Sat, 7 Feb 2015 13:41:50 -0500 >Subject: [PATCH] Bug 13680 - Items list on edit items page separates add > items form from header and sidebar > >This patch moves the items table on the edit items screen to the bottom of the page. > >Test plan: >1 - Apply patch >2 - Ensure adding/editing items works as previously > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >--- > .../prog/en/modules/cataloguing/additem.tt | 117 ++++++++++---------- > 1 file changed, 59 insertions(+), 58 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index 9cdc1cf..ddbf3b9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -134,9 +134,7 @@ $(document).ready(function() { > > <div id="bd"> > <div id="yui-main"> >- >-<h1>Items for [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</h1> >- >+<h1>Add items to [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</h1> > [% IF ( barcode_not_unique ) %]<div class="dialog alert"><strong>Error saving item</strong>: Barcode must be unique.</div>[% END %] > [% IF ( no_next_barcode ) %]<div class="dialog alert"><strong>Error saving items</strong>: Unable to automatically determine values for barcodes. No item has been inserted.</div>[% END %] > [% IF ( book_on_loan ) %]<div class="dialog alert"><strong>Cannot delete</strong>: item is checked out.</div>[% END %] >@@ -144,61 +142,7 @@ $(document).ready(function() { > [% IF ( not_same_branch ) %]<div class="dialog alert"><strong>Cannot delete</strong>: The items do not belong to your library.</div>[% END %] > [% IF ( linked_analytics ) %]<div class="dialog alert"><strong>Cannot delete</strong>: item has linked <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]&analyze=1">analytics.</a>.</div>[% END %] > >-<div id="cataloguing_additem_itemlist"> >- [% IF ( item_loop ) %] >- <div> >- <table id="itemst"> >- <thead> >- <tr> >- <th> </th> >- [% FOREACH item_header_loo IN item_header_loop %] >- <th> >- [% item_header_loo.header_value %] >- </th> >- [% END %] >- </tr> >- </thead> >- <tbody> >- [% FOREACH item_loo IN item_loop %] >- [% IF ( item_loo.itemnumber == itemnumber) %] >- [% IF item_loo.nomod %] >- <tr id="row[% item_loo.itemnumber %]" class="active"> >- [% ELSE %] >- <tr id="row[% item_loo.itemnumber %]" class="active editable"> >- [% END %] >- [% ELSE %] >- [% IF item_loo.nomod %] >- <tr id="row[% item_loo.itemnumber %]"> >- [% ELSE %] >- <tr id="row[% item_loo.itemnumber %]" class="editable"> >- [% END %] >- [% END %] >- [% IF ( item_loo.nomod ) %] >- <td> </td> >- [% ELSE %] >- <td> >- [% IF ( item_loo.hostitemflag ) %] >- <a href="additem.pl?op=edititem&biblionumber=[% item_loo.hostbiblionumber %]&itemnumber=[% item_loo.itemnumber %]#edititem">Edit in host</a> <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&biblionumber=[% biblionumber %]&hostitemnumber=[% item_loo.itemnumber %]">Delink</a> >- [% ELSE %] >- <a href="additem.pl?op=edititem&biblionumber=[% biblionumber %]&itemnumber=[% item_loo.itemnumber %]#edititem">Edit</a> >- [% IF ( item_loo.countanalytics ) %] >- <a href="/cgi-bin/koha/catalogue/search.pl?idx=hi&q=% item_loo.itemnumber %]">View analytics</a> >- [% ELSE %] >- <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&biblionumber=[% biblionumber %]&itemnumber=[% item_loo.itemnumber %]" onclick="confirm_deletion([% biblionumber %],[% item_loo.itemnumber %]); return false;">Delete</a> >- [% END %] >- [% END %] >- </td> >- [% END %] >- [% FOREACH item_valu IN item_loo.item_value %] >- <td>[% item_valu.field |html %]</td> >- [% END %] >- </tr> >- [% END %] >- </tbody> >- </table> >- </div> >- [% END %] >-</div> >+ > <div class="yui-gf"> > <div class="yui-u first"> > [% INCLUDE 'biblio-view-menu.inc' %] >@@ -278,6 +222,63 @@ $(document).ready(function() { > </div><!-- /yui-u --> > </div><!-- /yui-gf --> > >+<h1>Existing items for [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</h1> >+<div id="cataloguing_additem_itemlist"> >+ [% IF ( item_loop ) %] >+ <div> >+ <table id="itemst"> >+ <thead> >+ <tr> >+ <th> </th> >+ [% FOREACH item_header_loo IN item_header_loop %] >+ <th> >+ [% item_header_loo.header_value %] >+ </th> >+ [% END %] >+ </tr> >+ </thead> >+ <tbody> >+ [% FOREACH item_loo IN item_loop %] >+ [% IF ( item_loo.itemnumber == itemnumber) %] >+ [% IF item_loo.nomod %] >+ <tr id="row[% item_loo.itemnumber %]" class="active"> >+ [% ELSE %] >+ <tr id="row[% item_loo.itemnumber %]" class="active editable"> >+ [% END %] >+ [% ELSE %] >+ [% IF item_loo.nomod %] >+ <tr id="row[% item_loo.itemnumber %]"> >+ [% ELSE %] >+ <tr id="row[% item_loo.itemnumber %]" class="editable"> >+ [% END %] >+ [% END %] >+ [% IF ( item_loo.nomod ) %] >+ <td> </td> >+ [% ELSE %] >+ <td> >+ [% IF ( item_loo.hostitemflag ) %] >+ <a href="additem.pl?op=edititem&biblionumber=[% item_loo.hostbiblionumber %]&itemnumber=[% item_loo.itemnumber %]#edititem">Edit in host</a> <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&biblionumber=[% biblionumber %]&hostitemnumber=[% item_loo.itemnumber %]">Delink</a> >+ [% ELSE %] >+ <a href="additem.pl?op=edititem&biblionumber=[% biblionumber %]&itemnumber=[% item_loo.itemnumber %]#edititem">Edit</a> >+ [% IF ( item_loo.countanalytics ) %] >+ <a href="/cgi-bin/koha/catalogue/search.pl?idx=hi&q=% item_loo.itemnumber %]">View analytics</a> >+ [% ELSE %] >+ <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&biblionumber=[% biblionumber %]&itemnumber=[% item_loo.itemnumber %]" onclick="confirm_deletion([% biblionumber %],[% item_loo.itemnumber %]); return false;">Delete</a> >+ [% END %] >+ [% END %] >+ </td> >+ [% END %] >+ [% FOREACH item_valu IN item_loo.item_value %] >+ <td>[% item_valu.field |html %]</td> >+ [% END %] >+ </tr> >+ [% END %] >+ </tbody> >+ </table> >+ </div> >+ [% END %] >+</div> >+ > </div> > </div> > [% INCLUDE 'intranet-bottom.inc' %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13680
:
35720
|
35721
| 36128 |
36425
|
75706
|
75964
|
75965
|
82942