Created attachment 35720 [details] Proposed layout On records with multiple items attached the add items form can be pushed down the page, separating it from the header and sidebar and requiring a choice between where pages focus should fall and often leading to scrolling depending on your action. See bug 11905 A different solution would be to move the existing items list to the bottom of the page. This is a fairly striking difference, but with the addition of edit item links on the record detail page I don't think it makes selecting an item to edit more onerous. That being said, change is upsetting and I believe this would need some discussion.
Created attachment 35721 [details] [review] Bug 13680 - Items list on edit items page separates add items form from header and sidebar This patch moves the items table on the edit items screen to the bottom of the page. Test plan: 1 - Apply patch 2 - Ensure adding/editing items works as previously
Created attachment 36128 [details] [review] Bug 13680 - Items list on edit items page separates add items form from header and sidebar This patch moves the items table on the edit items screen to the bottom of the page. Test plan: 1 - Apply patch 2 - Ensure adding/editing items works as previously Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> I like this idea a lot. I think if everyone gave it a shot and got used to the work flow then everyone would love it.
Comment on attachment 36128 [details] [review] Bug 13680 - Items list on edit items page separates add items form from header and sidebar Review of attachment 36128 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ +134,4 @@ > > <div id="bd"> > <div id="yui-main"> > +<h1>Add items to [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</h1> Not sure this change is consistent: If you edit an item, you see: Add items to my_bib Edit Item #23192 There is Add vs Edit on the same page. Maybe it is better to keep the original wording here, don't you think?
Yeah, see your point, my only thought was it might seem odd to say "Items for TITLE_OF_BIB" when the items are not listed immediately. 'why I added the "Existing items for TITLE_OF_BIB" above the item list I am happy to keeping the wording as is, but maybe would prefer either: 1 - "Edit items for TITLE_OF_BIB" 2 - "TITLE_OF_BIB" and let the "Add item/Edit item #" indicate the current action
I am not sure yet if I am just 'ew change!' or if it's something else that bothers me. Still turning this around in my head, not feeling quite ready to pass QA. I'd like to get some more eyes on this.
I played around with the orignil an d the new version. My conclusion is that the new version (item list on bottom of the page) would be better. CSS patch follows as a proposition for formatting the form a little bit to make it more compact and better readable.
Created attachment 36425 [details] [review] Bug 13680 - Make form on edit items page more compact and better readable This patch makes the form on the edit items page more compact by decreasing the label font and indenting properly if a laberl has multiple rows. Additionally, a thin white line helps the eye to connect a label with the appropriate field. It is just a proposition regardless whether the form will be displayed above or below the items table.
I know it is a little late in the game, but just to stir up the pot a bit, what if the list was collapsed during edit? Show only the record being edited, and all other items are in an expandable list? The list would be expanded when not editing, and contracts during edit. The plus to this is you get to see the line, and there is less scrolling. Frankly, I don't think the edit screen should always be open. I think it leads to confusion as to whether you've got something new or editing something from the list. I would go as far as collapsing the edit list when not in use, or making it modal. Just my added two cents. Thoughts?
Hi Christopher, I had similar thoughts at this +1 for your suggestions.
(In reply to Christopher Brannon from comment #8) > I know it is a little late in the game, but just to stir up the pot a bit, > what if the list was collapsed during edit? Show only the record being > edited, and all other items are in an expandable list? The list would be > expanded when not editing, and contracts during edit. > > The plus to this is you get to see the line, and there is less scrolling. > > Frankly, I don't think the edit screen should always be open. I think it > leads to confusion as to whether you've got something new or editing > something from the list. I would go as far as collapsing the edit list when > not in use, or making it modal. Just my added two cents. > > Thoughts? +1 for modal!
Created attachment 75706 [details] [review] Bug 13680 - Items list on edit items page separates add items form from header and sidebar This is a proof of concept patch showing how I would improve this interface with a modal window for the item add form. The "views" menu is converted to a button menu. That goes against interface guidelines, but I don't see how else to handle it without taking up valuable screen real estate. This patch isn't complete--it doesn't handle edit operations. I just wanted to show the layout changes and how the "Add" button triggers the modal. Feeback welcome.
Created attachment 75964 [details] Screenshot showing views as dropdown menu
Created attachment 75965 [details] Screenshot showing entry form in modal
I love it! I'm not a cataloger, but I think it is a MASSIVE improvement as a modal. I would definitely go that direction. I also like the changes with View.
I like the modal, but not sure about the views in the menu. I often get asked in training on how to get to see the record after cataloguing and always point out the normal tab as the quickest option. This would add an extra click and make it less prominent.
I'm just looking at this for the first time, and I am a cataloger.:) I would love ANYTHING that gets me away from scrolling down through 200+ items to add an item!!! I can live with the modal--I often copy from an existing item in the table & paste into the new item, and with the model I'd simply do that from another browser tab, easy-peasy. My dream is that the "Actions" buttons (on the items in the item table) would have a "Duplicate" action that would allow me to clone an item that duplicated that item exactly except for $d and $p and I could then add a new barcode, edit the $h and/or $t and be done. Until then, this modal add item is a HUGE improvement. (Now, if I could get that "Duplicate" in the "Actions" button and launch that new item modal like this, I'd be living the dream!) I like the "View" button. I'm most often going directly from item editing to bib record editing (with Advanced Editor/Rancor), so don't mind one more click to get to "Normal." (I edit items first then go to Rancor because starting with Rancor then "Edit items" opens editing the items another tab, which I find annoying--I'd prefer it staying in the same tab.)
Created attachment 82942 [details] Screenshot showing alternate view menu What about this version of the view menu?
Ooooooh, Owen, I'm loving it!! And "MARC" vs. "Labeled MARC" is sweeeeeeeeet!!! This would make me a very happy cataloger! I'd like it now, please. --h2
Can the tabs be included in a dropdown on the edit modal? Should they be?
(In reply to Christopher Brannon from comment #19) > Can the tabs be included in a dropdown on the edit modal? Should they be? I wouldn't think that someone in the process of adding or editing an item would want to leave what they were doing to look at the record.
> I wouldn't think that someone in the process of adding or editing an item would > want to leave what they were doing to look at the record. This is correct for my workflow--it is extremely rare that I want to look back at the bib while editing/adding item(s), and in that rare case, I'll open the bib up in a different tab (or window) to preserved where I am in the item editing/adding workflow. I've usually done all the bib record examination that I need to do before editing/adding item(s). Usually. Ideally.:) --h2
*** Bug 23642 has been marked as a duplicate of this bug. ***
I definitely feel the modal and alternate view are the ways to go. Putting the table at the bottom would just disrupt the flow. I'm trying to get others to give input on this, but I think this is the direction we should move in.
This came up with a library recently. When adding an item to a record with over 50 items this is a lot of scrolling, but imagine a library with 200 items, massive amount of scrolling. I would love to see this move forward at this point . A collapsed option of all the items, and the ability to uncollapse? Owen's attachments are a definite improvement to what we are working with now.
(In reply to Kelly McElligott from comment #24) > This came up with a library recently. When adding an item to a record with > over 50 items this is a lot of scrolling, but imagine a library with 200 > items, massive amount of scrolling. I would love to see this move forward > at this point . A collapsed option of all the items, and the ability to > uncollapse? Owen's attachments are a definite improvement to what we are > working with now. +1