Bugzilla – Attachment 36139 Details for
Bug 9742
Confirm overlay prompt always appears on creating record from Z39.50
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 9742: Does not display the popup on creating new record
Signed-off-Bug-9742-Does-not-display-the-popup-on-.patch (text/plain), 1.80 KB, created by
Marc Véron
on 2015-02-24 12:48:21 UTC
(
hide
)
Description:
[Signed-off] Bug 9742: Does not display the popup on creating new record
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-02-24 12:48:21 UTC
Size:
1.80 KB
patch
obsolete
>From 6016cba9cd55d0625b5b155fde4d684f4827eecf Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 23 Feb 2015 17:09:20 +0100 >Subject: [PATCH] [Signed-off] Bug 9742: Does not display the popup on > creating new record >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The new confirmation on starting a z39.50 serach in cataloguing always >pops up, even when you are working on a new record that has not been >saved yet. > >Test plan: >1/ Edit an existing record, click on the Z3950 search button, confirm >the popup appears. >2/ Create a new record, click on the Z3950 search button, confirm >the popup does not appear. > >Followed test plan. Works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 26e3b62..9fd3909 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -69,10 +69,15 @@ > } > }); > >+ [%# Only ask for a confirmation if it is an edit %] > $("#z3950search").click(function(){ >- if (confirm(_("Please note that this external search could replace the current record."))){ >+ [% IF biblionumber %] >+ if (confirm(_("Please note that this external search could replace the current record."))){ >+ PopupZ3950(); >+ } >+ [% ELSE %] > PopupZ3950(); >- } >+ [% END %] > }); > > $("#saverecord").click(function(){ >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9742
:
36125
|
36139
|
36388