Attachment 36369 Details for Bug 10855 – Bug 10855: Fix QA issues

[patch] Bug 10855: Fix QA issues

Bug-10855-Fix-QA-issues.patch (text/plain), 4.27 KB, created by Brendan Gallagher on 2015-03-03 09:52:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Gallagher

Created: 2015-03-03 09:52:52 UTC

Size: 4.27 KB

patch

obsolete

>From 5ba35b7807965f12ab75d0377bda31c91e249f2c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 17 Dec 2013 13:53:21 +0100
>Subject: [PATCH] Bug 10855: Fix QA issues
>
>This patch fixes the following QA issues:
>
>FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>  FAIL   forbidden patterns
>       forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2)
>
>FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>  FAIL   forbidden patterns
>       forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2)
>
>FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
>  FAIL   forbidden patterns
>       forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12)
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt      |    4 +---
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt          |    4 ++--
> .../intranet-tmpl/prog/en/modules/serials/subscription-detail.tt   |    4 ++--
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
>index 6e1a290..27fb232 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
>@@ -9,9 +9,7 @@
> </title>
> [% INCLUDE 'doc-head-close.inc' %]
> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
>-<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.dataTables.min.js"></script>
>-[% INCLUDE 'datatables-strings.inc' %]
>-<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script>
>+[% INCLUDE "datatables.inc" %]
> <script type="text/javascript">
> //<![CDATA[
>   $(document).ready(function(){
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>index c3c9277..7f90e4c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>@@ -1,7 +1,7 @@
> [% USE Branches %]
> 
> [% INCLUDE 'doc-head-open.inc' %]
>-[% USE KohaAuthorisedValues %]
>+[% USE AuthorisedValues %]
>     <title>Koha &rsaquo; Serials &rsaquo; Claims</title>
>     [% INCLUDE 'doc-head-close.inc' %]
> [% INCLUDE 'calendar.inc' %]
>@@ -267,7 +267,7 @@
>                         </td>
>                         [% FOR field IN additional_fields_for_subscription %]
>                           [% IF field.authorised_value_category %]
>-                            <td>[% KohaAuthorisedValues.GetByCode( field.authorised_value_category, missingissue.additional_fields.${field.name} ) %]</td>
>+                            <td>[% AuthorisedValues.GetByCode( field.authorised_value_category, missingissue.additional_fields.${field.name} ) %]</td>
>                           [% ELSE %]
>                             <td>[% missingissue.additional_fields.${field.name} %]</td>
>                           [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>index 9222779..3c224de 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>@@ -1,5 +1,5 @@
> [% USE Branches %]
>-[% USE KohaAuthorisedValues %]
>+[% USE AuthorisedValues %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Serials &rsaquo; Details for subscription #[% subscriptionid %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -135,7 +135,7 @@ $(document).ready(function() {
>               <li>
>                 <span class="label">[% field.name %]:</span>
>                 [% IF field.authorised_value_category %]
>-                  [% KohaAuthorisedValues.GetByCode( field.authorised_value_category, additional_fields.${field.name} ) %]
>+                  [% AuthorisedValues.GetByCode( field.authorised_value_category, additional_fields.${field.name} ) %]
>                 [% ELSE %]
>                   [% additional_fields.${field.name} %]
>                 [% END %]
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10855: 20937 | 20938 | 20939 | 20940 | 20941 | 20942 | 20943 | 20944 | 21184 | 21185 | 21186 | 21187 | 21188 | 21189 | 21190 | 21191 | 21663 | 22049 | 22050 | 22051 | 22052 | 22053 | 22054 | 22055 | 22056 | 22057 | 22359 | 22360 | 22600 | 22601 | 22602 | 22603 | 22604 | 22605 | 22606 | 22607 | 22608 | 22616 | 22698 | 22699 | 22700 | 22701 | 22702 | 22703 | 22722 | 22768 | 22769 | 22869 | 23052 | 23053 | 23142 | 23143 | 23301 | 23302 | 23594 | 23595 | 23596 | 23597 | 23598 | 23599 | 23600 | 23601 | 23602 | 23774 | 23775 | 23961 | 23962 | 23963 | 23964 | 24452 | 24453 | 24454 | 24455 | 24456 | 24457 | 24569 | 24570 | 26091 | 26092 | 26093 | 26094 | 26095 | 26096 | 26097 | 26254 | 26255 | 26256 | 26257 | 26258 | 26259 | 26260 | 26276 | 26651 | 26655 | 28929 | 28930 | 28931 | 28932 | 28933 | 28934 | 28935 | 28936 | 28937 | 28938 | 28939 | 28940 | 28941 | 29095 | 29161 | 35211 | 35212 | 35213 | 35214 | 35215 | 35216 | 35217 | 35218 | 35219 | 35220 | 35221 | 35309 | 35310 | 35369 | 35556 | 36359 | 36362 | 36363 | 36364 | 36365 | 36366 | 36367 | 36368 | 36369 | 36370 | 36371 | 36372 | 36373 | 36374 | 38549 | 38550 | 38551 | 38552 | 38553 | 38554 | 38555 | 38556 | 38557 | 38558 | 38559 | 38560 | 38561 | 42296 | 42297 | 42298 | 42299 | 42300 | 42301 | 42302 | 42303 | 42304 | 42305 | 42306 | 42307 | 42308 | 42309 | 42310 | 42332 | 42333 | 43076