Bugzilla – Attachment 36565 Details for
Bug 13771
Koha 3.18 Help Files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13731: Suggestions reason does not save on updating the status
Bug-13731-Suggestions-reason-does-not-save-on-upda.patch (text/plain), 1.95 KB, created by
Biblibre Sandboxes
on 2015-03-05 11:09:38 UTC
(
hide
)
Description:
Bug 13731: Suggestions reason does not save on updating the status
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2015-03-05 11:09:38 UTC
Size:
1.95 KB
patch
obsolete
>From 6d25e9d7f06b6eb1ab79ae910c09d9146778dc76 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 23 Feb 2015 12:32:33 +0100 >Subject: [PATCH] Bug 13731: Suggestions reason does not save on updating the > status >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >On the suggestion list view, if you set a status, it won't be saved. > >Test plan: >1/ Create a suggestion >2/ Go on the suggestion list view (suggestion/suggestion.pl) >3/ Select a suggestion and marked it as "rejected" (or the status you >want) and choose a reason >4/ Save >5/ Browse you suggestions DB table (using your favorite MySQL CLI) and >verify that the "reason" field is correctly filled. > >Works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as expected, thx! > >Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> > >http://bugs.koha-community.org/show_bug.cgi?id=13771 >--- > suggestion/suggestion.pl | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index b54703a..3d10111 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -176,14 +176,11 @@ elsif ($op eq "change" ) { > } > if ( my $reason = $$suggestion_ref{"reason$tabcode"}){ > if ( $reason eq "other" ) { >- $reason = $$suggestion_ref{"other_reason$tabcode"}; >+ $reason = $$suggestion_ref{"other_reason$tabcode"}; > } >- $$suggestion_ref{'reason'}=$reason; >- } >- delete $$suggestion_ref{$_} foreach ("reason$tabcode", "other_reason$tabcode"); >- foreach (keys %$suggestion_ref){ >- delete $$suggestion_ref{$_} unless ($$suggestion_ref{$_}); >+ $suggestion_only->{reason}=$reason; > } >+ > foreach my $suggestionid (@editsuggestions) { > next unless $suggestionid; > $suggestion_only->{'suggestionid'}=$suggestionid; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13771
:
36267
|
36268
|
36269
|
36305
|
36319
|
36320
|
36325
|
36361
|
36375
|
36456
|
36500
|
36503
|
36547
|
36550
|
36551
|
36560
|
36561
|
36562
|
36563
|
36564
|
36565
|
36708
|
36709
|
36710
|
36711
|
36712
|
36713