To come.
Created attachment 36267 [details] 0001-Bug-13771-Main-Page-Help-fro-3.18
Created attachment 36268 [details] [review] [SIGNED-OFF] Bug 13771: Main Page Help fro 3.18 This updates the main page help file for 3.18. To test: * Log in to staff cleint * Click help on the mian page * Review help file
Created attachment 36269 [details] [review] BUG 13771: Update Tools Help Files for 3.18 To test: * Visit tools > batch record deletion * confirm help is right * Visit tools > Notices & Slips * confirm help is right * Visit tools > export marc * cofirm the help is right
Created attachment 36305 [details] [review] [SIGNED-OFF] BUG 13771: Update Tools Help Files for 3.18 This patch creates a helpf ile for the batch record delete tool and updates the help files for notices and marc export. To test: * Visit tools > batch record deletion * confirm help is right * Visit tools > Notices & Slips * confirm help is right * Visit tools > export marc * cofirm the help is right
Created attachment 36319 [details] [review] [SIGNED OFF] BUG 13771: Update Tools Help Files for 3.18 This patch creates a helpf ile for the batch record delete tool and updates the help files for notices and marc export. To test: * Visit tools > batch record deletion * confirm help is right * Visit tools > Notices & Slips * confirm help is right * Visit tools > export marc * cofirm the help is right Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Created attachment 36320 [details] [review] [SIGNED OFF] Bug 13771: Main Page Help fro 3.18 This updates the main page help file for 3.18. To test: * Log in to staff cleint * Click help on the mian page * Review help file Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Created attachment 36325 [details] [review] Bug 13771: Update Circ Help File This updates the main circulation help file with new features in 3.18. To test: * visit circulation page * click help * review text
Created attachment 36361 [details] [review] [SIGNED OFF] Bug 13771: Update Circ Help File This updates the main circulation help file with new features in 3.18. To test: * visit circulation page * click help * review text Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/circulation.tt FAIL forbidden patterns forbidden pattern: tab char (line 79) forbidden pattern: tab char (line 16) OK tt_valid OK valid_template
Created attachment 36375 [details] [review] Bug 13771: Add admin help files for 3.18 This patch adds a new help file for column settings and updates the files for budgets, funds, libraries, patron categories, and circ rules. To test: * Visit the above listed admin pages * Review help files
Brendan, All of the help files have tabs because they are HTML and this is okay (according to the conversation with Katrin at hackfest). Thanks, Nicole
The newest patch (admin help for 3.18) needs sign off. Nicole
(In reply to Nicole C. Engard from comment #12) > The newest patch (admin help for 3.18) needs sign off. > > Nicole On help/admin/branches.tt, it's 'New library' and 'New group', not with capitalized second word There are similar cases on the other files, but that predates this bug. koha-qa complains about tabs, not all of them, only the new ones that you are introducing :)
Created attachment 36456 [details] [review] [SIGNED OFF] Bug 13771: Add admin help files for 3.18 This patch adds a new help file for column settings and updates the files for budgets, funds, libraries, patron categories, and circ rules. To test: * Visit the above listed admin pages * Review help files Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Created attachment 36500 [details] [review] Bug 13771: Add missing item search help file This patch adds a help file for the staff item search. To test: * Click search * click item search * click help * review the help file
Created attachment 36503 [details] [review] Bug 13771: Add missing item search help file This patch adds a help file for the staff item search. To test: * Click search * click item search * click help * review the help file Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Item search help works for me. I noticed that about the first half of the text is a description of how to get to the very page you open that help file from, I'm not sure it is very helpful in this context. :)
Created attachment 36547 [details] [review] Bug 13771: Update manage staged marc help for 3.18 This updates the manage staged marc files help. To test: * Visit Tools > Staged MARC record management * Click help * Confirm it's there and correct
Created attachment 36550 [details] [review] [SIGNED OFF] Bug 13771: Update manage staged marc help for 3.18 This updates the manage staged marc files help. To test: * Visit Tools > Staged MARC record management * Click help * Confirm it's there and correct Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com>
Created attachment 36551 [details] [review] [SIGNED OFF] Bug 13771: Update manage staged marc help for 3.18 This updates the manage staged marc files help. To test: * Visit Tools > Staged MARC record management * Click help * Confirm it's there and correct Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com>
Patch tested with a sandbox, by JA <aloi54@live.fr>
Created attachment 36560 [details] [review] Bug 13753: koha-indexer contains invalid statement An incorrect conditional makes the indexer daemon fail to load. To test: - Enable the indexer daemon on packages [1] - Restart koha-common: $ service koha-common restart - Run $ ps waux | grep koha-indexer => FAIL: there's no reference to the rebuild_zebra.pl script (line should look like *rebuild_zebra.pl -daemon*) Run ps -ef | grep rebuild_zebra.pl too to make sure. - Apply the patch, repeat the steps => SUCCESS: the rebuild_zebra.pl script is ran - Sign off :-D Thanks Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 36561 [details] [review] Bug 13759 - git-build-snapshot misses YUI and dies of sorrow during build Due to a line in debian/rules, git-build-snapshot tries to delete a YUI-related path that does not exist anymore (bug 13612 I guess). Build process ends with an error. This patch deletes the line. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 36562 [details] [review] Bug 13676 - OpacSuppression description says 'items' but means 'records' This patch changes the wording for the OpacSuppression preference description. Without patch: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed item, or your searches will be broken. ... With patch: ... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed biblio record, or your searches will be broken. ... Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 36563 [details] [review] Bug 13741: "No fund found" is not translatable The string "No fund found" on the funds overview page is not translatable. To test: - Create a new budget - Check for the string on the funds page of the new budget - Run an update on one of the po file sets cd misc/translator perl translate update <langcode> - Verify that the string now appars in the po file for staff - Verify the page still looks the same as before the patch Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 36564 [details] [review] Bug 13745: Fix serial collection page to always show branch name The serial collection page shows 2 tables, one for the subscriptions and a second for the issues. Both show the branch, but the first showed the code while the second showed the name. With this patch both tables show the name. To test: - Search for a subscription or create one - Navigate to the serial collection page (navigation on left side) - Check both tables on the page show the branch name with the patch applied Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 36565 [details] [review] Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, thx! Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Something has gone really wrong on here, the sandbox has attached a bunch of unrelated patches.
Created attachment 36708 [details] [review] [PASSED QA] BUG 13771: Update Tools Help Files for 3.18 This patch creates a helpf ile for the batch record delete tool and updates the help files for notices and marc export. To test: * Visit tools > batch record deletion * confirm help is right * Visit tools > Notices & Slips * confirm help is right * Visit tools > export marc * cofirm the help is right Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36709 [details] [review] [PASSED QA] Bug 13771: Main Page Help fro 3.18 This updates the main page help file for 3.18. To test: * Log in to staff cleint * Click help on the mian page * Review help file Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36710 [details] [review] [PASSED QA] Bug 13771: Update Circ Help File This updates the main circulation help file with new features in 3.18. To test: * visit circulation page * click help * review text Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36711 [details] [review] [PASSED QA] Bug 13771: Add admin help files for 3.18 This patch adds a new help file for column settings and updates the files for budgets, funds, libraries, patron categories, and circ rules. To test: * Visit the above listed admin pages * Review help files Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36712 [details] [review] [PASSED QA] Bug 13771: Add missing item search help file This patch adds a help file for the staff item search. To test: * Click search * click item search * click help * review the help file Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36713 [details] [review] [PASSED QA] Bug 13771: Update manage staged marc help for 3.18 This updates the manage staged marc files help. To test: * Visit Tools > Staged MARC record management * Click help * Confirm it's there and correct Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Nice job Nicole!
Pushed to 3.18.x will be in 3.18.5