Attachment 37451 Details for Bug 12210 – Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated

[patch] Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated

Bug-12210---Baker--Taylor-book-jackets-not-disable.patch (text/plain), 3.81 KB, created by Kyle M Hall (khall) on 2015-04-03 12:16:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-04-03 12:16:49 UTC

Size: 3.81 KB

patch

obsolete

>From 66264857809fb465e1d7ea501d88d5246790b503 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 3 Apr 2015 08:14:47 -0400
>Subject: [PATCH] Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated
>
>The description of the BakerTaylorBookstoreURL syspref says
>"Baker and Taylor "My Library Bookstore" links should be accessed at
>https:// isbn (this should be filled in with something like
>ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=).
>Leave it blank to disable these links."
>
>Leaving this syspref blank does not disable the links. Instead, they are
>populated without the bookstore URL: the cover image for ISBN 1575725738
>will cause koha to make a request to http://1575725738, which will, of
>course, time out.
>
>Leaving BakerTaylorBookstoreURL blank should disable any URL that
>depends on this syspref, as stated in the syspref description.
>
>Test Plan:
>1) Apply this patch
>2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL
>3) Perform an OPAC search where you have B&T cover images in the results
>4) Note the image links now direct you to the record details
>---
> .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 14 ++++++++++++--
> 1 files changed, 12 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index 948c069..44a1d5c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -273,11 +273,21 @@
> No cover image available
> [% END %]
> [% END %]
>+
>+ [% IF ( BakerTaylorEnabled && !BakerTaylorBookstoreURL ) %]
>+ [% IF ( SEARCH_RESULT.normalized_isbn ) %]
>+ <img alt="See Baker &amp; Taylor" src="[% BakerTaylorImageURL |html %][% SEARCH_RESULT.normalized_isbn %]" />
>+ [% ELSE %]
>+ No cover image available
>+ [% END %]
>+ [% END %]
> </a>
> 
>- [% IF ( BakerTaylorEnabled ) %]
>+ [% IF ( BakerTaylorEnabled && BakerTaylorBookstoreURL ) %]
> [% IF ( SEARCH_RESULT.normalized_isbn ) %]
>- <a href="https://[% BakerTaylorBookstoreURL |html %][% SEARCH_RESULT.normalized_isbn %]"><img alt="See Baker &amp; Taylor" src="[% BakerTaylorImageURL |html %][% SEARCH_RESULT.normalized_isbn %]" /></a>
>+ <a href="https://[% BakerTaylorBookstoreURL |html %][% SEARCH_RESULT.normalized_isbn %]">
>+ <img alt="See Baker &amp; Taylor" src="[% BakerTaylorImageURL |html %][% SEARCH_RESULT.normalized_isbn %]" />
>+ </a>
> [% ELSE %]
> No cover image available
> [% END %]
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 12210: 37451 | 37529 | 37530 | 37551