Bugzilla – Attachment 37596 Details for
Bug 9333
Confirm close JavaScript alerts is not used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9333: Remove useless JS code - confirm close basket
Bug-9333-Remove-useless-JS-code---confirm-close-ba.patch (text/plain), 1.88 KB, created by
Mark Tompsett
on 2015-04-09 05:47:54 UTC
(
hide
)
Description:
Bug 9333: Remove useless JS code - confirm close basket
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2015-04-09 05:47:54 UTC
Size:
1.88 KB
patch
obsolete
>From d14aa318febdaf4f3816da6fb341e70312fb7884 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 8 Apr 2015 12:47:43 +0200 >Subject: [PATCH] Bug 9333: Remove useless JS code - confirm close basket > >On closing a basket, the librarian is redirect to a new page for the >confirmation, the JavaScript confirmation is useless. > >This code is never triggered and can be removed. > >Test plan: >Without this patch, confirm you don't get a JavaScript confirmation >popup on closing a basket >With this patch, confirm you don't get any JavaScript error on >closing/reopening a basket. > >NOTE: acqui/basket.tt is only used by acqui/basket.pl > git grep "confirm_close" | grep -v "\.po:" > doesn't show anything else. Reopening only works on > basketgroups, not baskets. Unable to trigger any errors > as expected and desired. :) > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 ------ > 1 file changed, 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index b68a62b..22d6631 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -40,12 +40,6 @@ > [% UNLESS ( closedate ) %] > <script type="text/javascript"> > //<![CDATA[ >- function confirm_close() { >- var is_confirmed = confirm(_("Are you sure you want to close this basket?")); >- if (is_confirmed) { >- window.location = "[% script_name %]?op=close&basketno=[% basketno %]"; >- } >- } > > function delete_basket(basketno,booksellerid,delbiblio) { > window.location = "[% script_name %]?op=delete_confirm&delbiblio="+delbiblio+"&basketno="+basketno+"&booksellerid="+booksellerid; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9333
:
37574
|
37596
|
37654