The templates contain JavaScript intended to warn the user before they close or reopen a basket. They never fire because the templates don't trigger them anywhere. If these warnings are still useful they should be enabled.
Hi Owen, I think those are probably not in Boostrap - can we close the bug?
Ok, I misunderstood - this is about baskets in acquisitions. If you try to reopen a basket, a javascript alert is triggered. But when you close a basket, there is a non-javascript alert.
Created attachment 37574 [details] [review] Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket.
Created attachment 37596 [details] [review] Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket. NOTE: acqui/basket.tt is only used by acqui/basket.pl git grep "confirm_close" | grep -v "\.po:" doesn't show anything else. Reopening only works on basketgroups, not baskets. Unable to trigger any errors as expected and desired. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 37654 [details] [review] [PASSED QA] Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket. NOTE: acqui/basket.tt is only used by acqui/basket.pl git grep "confirm_close" | grep -v "\.po:" doesn't show anything else. Reopening only works on basketgroups, not baskets. Unable to trigger any errors as expected and desired. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!