Bugzilla – Attachment 3807 Details for
Bug 6123
Request to find borrowers without issues overload the server
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Optimization of the SQL request
0001-Bug-6123-Optimization-of-the-SQL-request-using-NOT-E.patch (text/plain), 1.88 KB, created by
Alex Arnaud
on 2011-04-07 14:56:33 UTC
(
hide
)
Description:
Optimization of the SQL request
Filename:
MIME Type:
Creator:
Alex Arnaud
Created:
2011-04-07 14:56:33 UTC
Size:
1.88 KB
patch
obsolete
>From d16f6cec44b72b7898d8c7f56efa6679e0408d88 Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Thu, 7 Apr 2011 16:55:08 +0200 >Subject: [PATCH] Bug #6123 - Optimization of the SQL request using NOT EXISTS instead of NOT IN > >--- > reports/borrowers_out.pl | 19 ++++++------------- > 1 files changed, 6 insertions(+), 13 deletions(-) > >diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl >index 0a135e1..ed0fc0b 100755 >--- a/reports/borrowers_out.pl >+++ b/reports/borrowers_out.pl >@@ -229,19 +229,12 @@ sub calculate { > $strcalc .= "WHERE 1 "; > @$filters[0]=~ s/\*/%/g if (@$filters[0]); > $strcalc .= " AND borrowers.categorycode like '" . @$filters[0] ."'" if ( @$filters[0] ); >- >- my $strqueryfilter = "SELECT DISTINCT borrowernumber FROM "; >- $strqueryfilter .= "(SELECT borrowernumber from old_issues WHERE borrowernumber IS NOT NULL "; >- if ($filters->[1]){ >- $strqueryfilter .= "AND old_issues.timestamp> '$filters->[1]' "; >- } >- $strqueryfilter .= "UNION SELECT borrowernumber FROM issues WHERE 1 "; >- if ($filters->[1]){ >- $strqueryfilter .= "AND issues.timestamp> '$filters->[1]' "; >- } >- $strqueryfilter .= ") active_borrowers"; >- >- $strcalc .= " AND borrowers.borrowernumber not in ($strqueryfilter)"; >+ $strcalc .= " AND NOT EXISTS (SELECT * FROM issues WHERE issues.borrowernumber=borrowers.borrowernumber "; >+ $strcalc .= " AND issues.timestamp> '" . @$filters[1] . "'" if (@$filters[1]); >+ $strcalc .= ") "; >+ $strcalc .= " AND NOT EXISTS (SELECT * FROM old_issues WHERE old_issues.borrowernumber=borrowers.borrowernumber "; >+ $strcalc .= " AND old_issues.timestamp> '" . @$filters[1] . "'" if (@$filters[1]); >+ $strcalc .= ") "; > $strcalc .= " group by borrowers.borrowernumber"; > $strcalc .= ", $colfield" if ($column); > $strcalc .= " order by $colfield " if ($colfield); >-- >1.6.3.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6123
: 3807