Attachment 38149 Details for Bug 6059 – Bug 6059: Don't permit to change the quantity when items are created on ordering

[patch] Bug 6059: Don't permit to change the quantity when items are created on ordering

Bug-6059-Dont-permit-to-change-the-quantity-when-i.patch (text/plain), 2.50 KB, created by Mark Tompsett on 2015-04-20 02:11:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2015-04-20 02:11:57 UTC

Size: 2.50 KB

patch

obsolete

>From 68e44163b5c4a119a8b104169040c55a70a1975d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 8 Apr 2015 10:04:40 +0200
>Subject: [PATCH] Bug 6059: Don't permit to change the quantity when items are
> created on ordering
>
>If items are created on ordering, the quantity for uncertain prices
>should not be editable.
>
>Test plan:
>0/ Set AcqCreateItem to "on ordering"
>1/ Create a basket and add an order with 1+ items
>2/ Mark it as uncertain prices
>3/ Go on the uncertain prices page for this vendor
>(acqui/uncertainprice.pl?booksellerid=X)
>4/ Confirm you are not allowed to update the quantity
>5/ Change the price and save
>6/ Confirm the quantity is still correct
>
>Set the pref to another value and confirm the behavior has not changed.
>
>NOTE: Tested with 'on placing order' and 'on receiving order'.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> .../intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt      | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>index a503f2b..df50898 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>@@ -1,3 +1,4 @@
>+[% USE Koha %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Acquisitions &rsaquo; [% IF ( booksellername ) %]Orders with uncertain prices for vendor [% booksellername %][% ELSE %]Orders with uncertain prices[% END %]</title>
> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
>@@ -126,8 +127,13 @@ function check(form) {
> 	    </td>
> 	    <td>
> 	        
>-	        <input type="text" size="10" name="qty[% uncertainpriceorder.ordernumber %]" value="[% uncertainpriceorder.quantity %]"
>-	                                        onchange="uncheckbox(this.form, [% uncertainpriceorder.ordernumber %]);" />
>+        [% IF Koha.Preference('AcqCreateItem') == 'ordering' %]
>+            [% uncertainpriceorder.quantity %]
>+            <input type="hidden" name="qty[% uncertainpriceorder.ordernumber %]" value="[% uncertainpriceorder.quantity %]" />
>+        [% ELSE %]
>+            <input type="text" size="10" name="qty[% uncertainpriceorder.ordernumber %]" value="[% uncertainpriceorder.quantity %]"
>+                    onchange="uncheckbox(this.form, [% uncertainpriceorder.ordernumber %]);" />
>+        [% END %]
> 	    </td>
> 	    </tr>
> 	    [% END %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 6059: 37560 | 38149 | 38153