Attachment 38208 Details for Bug 13838 – Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold

[patch] Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold

Bug-13838---Redirect-to-expired-holds-tab-after-ca.patch (text/plain), 1.23 KB, created by Kyle M Hall (khall) on 2015-04-20 19:36:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-04-20 19:36:14 UTC

Size: 1.23 KB

patch

obsolete

>From 2e60961860c7e27d8eea334c242c2c31aa05a8a1 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 20 Apr 2015 12:31:11 -0700
>Subject: [PATCH] Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold
>
>When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length.
>
>Test Plan:
>1) Apply this patch
>2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl
>3) Note you are redirected back to the holds over tab
>---
> circ/waitingreserves.pl |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl
>index fb7a3d1..7d4cbf9 100755
>--- a/circ/waitingreserves.pl
>+++ b/circ/waitingreserves.pl
>@@ -158,7 +158,9 @@ $template->param(
>     ReservesMaxPickUpDelay => C4::Context->preference('ReservesMaxPickUpDelay')
> );
> 
>-if ($cancelall) {
>+if ($item) {
>+    print $input->redirect("/cgi-bin/koha/circ/waitingreserves.pl#holdsover");
>+} elsif ($cancelall) {
>     print $input->redirect("/cgi-bin/koha/circ/waitingreserves.pl");
> } else {
>     output_html_with_http_headers $input, $cookie, $template->output;
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 13838: 38208 | 45531 | 45556 | 45596