Attachment 39314 Details for Bug 9314 – [SIGNED-OFF] Bug 9314: Remove useless code related to the type_only parameter

[patch] [SIGNED-OFF] Bug 9314: Remove useless code related to the type_only parameter

SIGNED-OFF-Bug-9314-Remove-useless-code-related-to.patch (text/plain), 2.75 KB, created by Bernardo Gonzalez Kriegel on 2015-05-19 18:48:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2015-05-19 18:48:30 UTC

Size: 2.75 KB

patch

obsolete

>From 4259c4b15fa7f4614bfe8f7aea2d419ecd641c0c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 8 Apr 2015 13:29:28 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 9314: Remove useless code related to the
> type_only parameter
>
>Since the pref AddPatronLists has been removed in bug 13497, the code
>related to type_only and category_type in memberentry.pl is useless.
>
>Test plan:
>Confirm you don't the information message.
>You can also confirm that the message was wrong and nothing was saved.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Dead code removed, no errors
>
>Think that bug description can be updated to commit message
>---
> .../prog/en/modules/members/memberentrygen.tt      |    3 ---
> members/memberentry.pl                             |    6 +-----
> 2 files changed, 1 insertion(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 330058f..8dd0903 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1066,9 +1066,6 @@
>     </script>
>     [% END %]
>     <input type="hidden" name="setting_messaging_prefs" value="1" />
>-    [% IF type_only %]
>-        <p>If no preferences are selected, the default preferences for the category chosen will be applied on save, otherwise your selection here is saved</p>
>-    [% END %]
>     [% INCLUDE 'messaging-preference-form.inc' %]
>     [% IF ( SMSSendDriver ) %]
>         <p><label for="SMSnumber">SMS number:</label>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 22bceab..3de7d75 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -150,16 +150,12 @@ $template->param( "checked" => 1 ) if ( defined($nodouble) && $nodouble eq 1 );
> ( $borrower_data = GetMember( 'borrowernumber' => $borrowernumber ) ) if ( $op eq 'modify' or $op eq 'save' or $op eq 'duplicate' );
> my $categorycode  = $input->param('categorycode') || $borrower_data->{'categorycode'};
> my $category_type = $input->param('category_type') || '';
>-if ($category_type){
>-    $template->{VARS}->{'type_only'} = 1;
>-}
>-my $new_c_type = $category_type; #if we have input param, then we've already chosen the cat_type.
> unless ($category_type or !($categorycode)){
>     my $borrowercategory = GetBorrowercategory($categorycode);
>     $category_type    = $borrowercategory->{'category_type'};
>     my $category_name = $borrowercategory->{'description'}; 
>     $template->param("categoryname"=>$category_name);
>- }
>+}
> $category_type="A" unless $category_type; # FIXME we should display a error message instead of a 500 error !
> 
> # if a add or modify is requested => check validity of data.
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9314: 37577 | 39314 | 39957