Bugzilla – Attachment 3979 Details for
Bug 6234
Links on hold ratios report broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Corrected patch
0001-Bug-6234-Fixing-missing-biblionumber-for-links-using.patch (text/plain), 9.12 KB, created by
Katrin Fischer
on 2011-04-21 17:38:35 UTC
(
hide
)
Description:
Corrected patch
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2011-04-21 17:38:35 UTC
Size:
9.12 KB
patch
obsolete
>From 207160ea9c427b3b31631c93e5cbc0b240ff79f3 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Wed, 20 Apr 2011 07:27:23 +0200 >Subject: [PATCH] Bug 6234: Fixing missing biblionumber for links using biblio-default-view.inc >Content-Type: text/plain; charset="utf-8" > >Fixes various pages where the biblionumber was missing in links to the detail page of a record. >Should also fix 6241. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >I made the changes Owen suggested >- added the class="ratiolimit" back >- fixed additional link in waitingreserve.tt >--- > .../prog/en/modules/circ/branchoverdues.tt | 2 +- > .../intranet-tmpl/prog/en/modules/circ/overdue.tt | 2 +- > .../prog/en/modules/circ/pendingreserves.tt | 2 +- > .../prog/en/modules/circ/reserveratios.tt | 2 +- > .../prog/en/modules/circ/transferstoreceive.tt | 2 +- > .../prog/en/modules/circ/waitingreserves.tt | 4 ++-- > .../prog/en/modules/virtualshelves/shelves.tt | 2 +- > 7 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >index 7d5ea13..a8a8912 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >@@ -43,7 +43,7 @@ > [% overduesloo.date_due %] > </td> > <td> >- [% INCLUDE 'biblio-default-view.inc' %][% overduesloo.title |html %] [% IF ( overduesloo.subtitle ) %][% overduesloo.subtitle %][% END %]</a> [% IF ( overduesloo.author ) %] by [% overduesloo.author %][% END %] >+ [% INCLUDE 'biblio-default-view.inc' biblionumber = overduesloo.biblionumber %][% overduesloo.title |html %] [% IF ( overduesloo.subtitle ) %][% overduesloo.subtitle %][% END %]</a> [% IF ( overduesloo.author ) %] by [% overduesloo.author %][% END %] > > <br />Barcode : [% overduesloo.barcode %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >index 9be6c35..9f4ec8d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >@@ -120,7 +120,7 @@ > [% IF ( overdueloo.email ) %][<a href="mailto:[% overdueloo.email %]?subject=Overdue: [% overdueloo.title |html %]">email</a>][% END %] > ([% IF ( overdueloo.phone ) %][% overdueloo.phone %][% ELSIF ( overdueloo.mobile ) %][% overdueloo.mobile %][% ELSIF ( overdueloo.phonepro ) %][% overdueloo.phonepro %][% END %])</td> > <td>[% overdueloo.branchcode %]</td> >- <td>[% INCLUDE 'biblio-default-view.inc' %][% overdueloo.title |html %] [% overdueloo.subtitle %]</a> [% IF ( overdueloo.author ) %], by [% overdueloo.author %][% END %] >+ <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = overdueloo.biblionumber %][% overdueloo.title |html %] [% overdueloo.subtitle %]</a> [% IF ( overdueloo.author ) %], by [% overdueloo.author %][% END %] > </td> > <td><a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% overdueloo.biblionumber %]&itemnumber=[% overdueloo.itemnum %]#item[% overdueloo.itemnum %]">[% overdueloo.barcode %]</a></td> > <td>[% overdueloo.itemcallnumber %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index 75fcb52..5668a75 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -118,7 +118,7 @@ $.tablesorter.addParser({ > <td>[% reserveloo.rcount %]</td> > <td> > <p> >- [% INCLUDE 'biblio-default-view.inc' %] >+ [% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %] > [% reserveloo.title |html %] [% reserveloo.subtitle %] > </a> > </p> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >index c14a323..30e676e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt >@@ -91,7 +91,7 @@ $.tablesorter.addParser({ > <td><p>[% reserveloo.reservecount %]</p></td> > <td><p>[% reserveloo.itemcount %]</p></td> > <td><p class="ratiolimit">[% reserveloo.thisratio %]</p></td> >- <td>[% INCLUDE 'biblio-default-view.inc' %][% reserveloo.title |html %] [% IF ( reserveloo.subtitle ) %][% FOREACH subtitl IN reserveloo.subtitle %][% subtitl.subfield %][% END %][% END %]</a>[% IF ( reserveloo.author ) %] by [% reserveloo.author %][% END %] >+ <td> [% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %][% reserveloo.title |html %] [% IF ( reserveloo.subtitle ) %][% FOREACH subtitl IN reserveloo.subtitle %][% subtitl.subfield %][% END %][% END %]</a>[% IF ( reserveloo.author ) %] by [% reserveloo.author %][% END %] > </td> > <td><p>[% reserveloo.listbranch %]</p></td> > <td><p>[% reserveloo.location %]</p></td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt >index c999108..50d7ae3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt >@@ -59,7 +59,7 @@ $(document).ready(function() { > [% END %] > <td><p>[% reser.datetransfer %]</p> [% IF ( reser.messcompa ) %]<span class="error">Transfer is [% reser.diff %] days late</span>[% END %]</td> > <td><span style="display:none;">[% reser.title |html %]</span><!-- invisible title for tablesorter --> >- [% INCLUDE 'biblio-default-view.inc' %][% reser.title |html %] [% IF ( reser.subtitle ) %] [% FOREACH subtitl IN reser.subtitle %][% subtitl.subfield %][% END %][% END %]</a> [% IF ( reser.author ) %]by [% reser.author %][% END %] >+ [% INCLUDE 'biblio-default-view.inc' biblionumber = reser.biblionumber %][% reser.title |html %] [% IF ( reser.subtitle ) %] [% FOREACH subtitl IN reser.subtitle %][% subtitl.subfield %][% END %][% END %]</a> [% IF ( reser.author ) %]by [% reser.author %][% END %] > [% IF ( reser.itemtype ) %] (<b>[% reser.itemtype %]</b>)[% END %] > <br />Barcode: [% reser.barcode %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >index 5c92d46..39400bf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >@@ -84,7 +84,7 @@ $.tablesorter.addParser({ > <tbody>[% FOREACH reserveloo IN reserveloop %] > <tr> > <td><p>[% reserveloo.waitingdate %]</p></td> >- <td>[% INCLUDE 'biblio-default-view.inc' %] >+ <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %] > [% reserveloo.title |html %] [% reserveloo.subtitle |html %] > </a> > (<b>[% reserveloo.itemtype %]</b>) >@@ -129,7 +129,7 @@ $.tablesorter.addParser({ > <tbody>[% FOREACH overloo IN overloop %] > <tr> > <td><p>[% overloo.waitingdate %]</p></td> >- <td>[% INCLUDE 'biblio-default-view.inc' %][% overloo.title |html %] [% overloo.subtitle |html %] >+ <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = overloo.biblionumber %][% overloo.title |html %] [% overloo.subtitle |html %] > </a> > [% UNLESS ( item_level_itypes ) %][% IF ( overloo.itemtype ) %] (<b>[% overloo.itemtype %]</b>)[% END %][% END %] > <br />Barcode: [% overloo.barcode %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index e4db620..d6ffbcf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -196,7 +196,7 @@ function placeHold () { > [% UNLESS ( noItemTypeImages ) %]<img src="[% itemsloo.imageurl %]" alt="[% itemsloo.description %]" title="[% itemsloo.description %]" />[% END %][% itemsloo.description %] > </td>[% END %] > <td> >- [% INCLUDE 'biblio-default-view.inc' %] >+ [% INCLUDE 'biblio-default-view.inc' biblionumber = itemsloo.biblionumber %] > [% itemsloo.title |html %][% FOREACH subtitl IN itemsloo.subtitle %] [% subtitl.subfield %][% END %]</a> > </td> > <td>[% itemsloo.author %]</td> >-- >1.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6234
:
3973
| 3979