Attachment 39833 Details for Bug 14325 – Bug 14325: Test calls C4::Context::set_userenv

[patch] Bug 14325: Test calls C4::Context::set_userenv

Bug-14325-Test-calls-C4Contextsetuserenv.patch (text/plain), 1.52 KB, created by Marcel de Rooy on 2015-06-04 07:52:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-06-04 07:52:08 UTC

Size: 1.52 KB

patch

obsolete

>From 96db5484e746002d5f653a413ff021599e2ed2e2 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Wed, 3 Jun 2015 15:25:47 -0400
>Subject: [PATCH] Bug 14325: Test calls C4::Context::set_userenv
>Content-Type: text/plain; charset=utf-8
>
>This is a case of works by accident. This patch corrects the
>set_userenv call.
>
>TEST PLAN
>---------
>1) prove t/db_dependent/Borrower_Discharge.t
>   -- works
>2) git grep :set_userenv
>   -- only this one file.
>3) Confirm the the C4/Context.pm has a set_userenv
>   which shifts the first parameter, as intended for
>   a -> call and not a :: call.
>4) apply patch
>5) prove t/db_dependent/Borrower_Discharge.t
>   -- still works
>6) git grep :set_userenv
>   -- nothing now.
>7) run koha qa test tools
>
>Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Borrower_Discharge.t |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Borrower_Discharge.t b/t/db_dependent/Borrower_Discharge.t
>index cb5179f..b585db2 100644
>--- a/t/db_dependent/Borrower_Discharge.t
>+++ b/t/db_dependent/Borrower_Discharge.t
>@@ -20,7 +20,7 @@ $dbh->{RaiseError} = 1;
> $dbh->do(q|DELETE FROM discharges|);
> 
> C4::Context->_new_userenv('xxx');
>-C4::Context::set_userenv(0, 0, 0, 'firstname', 'surname', 'CPL', 'CPL', '', '', '');
>+C4::Context->set_userenv(0, 0, 0, 'firstname', 'surname', 'CPL', 'CPL', '', '', '', '', '');
> 
> my $borrowernumber = AddMember(
>     cardnumber => 'UTCARD1',
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14325: 39826 | 39828 | 39833