Bugzilla – Attachment 39962 Details for
Bug 8330
Overdues email subject contains untranslatable 'Overdue:' string
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8330: Overdue email link contains untranslatable 'Overdue:'
Bug-8330-Overdue-email-link-contains-untranslatabl.patch (text/plain), 3.29 KB, created by
Katrin Fischer
on 2015-06-07 23:01:03 UTC
(
hide
)
Description:
Bug 8330: Overdue email link contains untranslatable 'Overdue:'
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-06-07 23:01:03 UTC
Size:
3.29 KB
patch
obsolete
>From 543a82e8bc3f2d6c6d5bcff3dfa339bec70f6422 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Mon, 8 Jun 2015 00:55:22 +0200 >Subject: [PATCH] Bug 8330: Overdue email link contains untranslatable > 'Overdue:' > >The translation scripts don't pick up text from href attributes, >which is what we want, with a small exception for this script. > >Patch uses a TT trick to make the Overdue: in the subject >of the mailto: link translatable. > >Regression test: >- Make sure you have an overdue item >- Go to Circulation > Overdues >- Verify the [email] link works and a subject > with 'Overdue: <title>' is generated >- Apply patch and repeat steps > >Bonus: Verify the branch name now shows instead of > the branchcode in the table > >To test translatability: >- cd misc/translator >- perl translate update de-DE >- Open file po/de-DE-staff-prog.po >- Search for Overdue: >- Translate string, remove 'fuzzy' marker >- perl translate install de-DE >- Test again, subject should now be translated >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >index 553bcf8..c1aa428 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >@@ -2,6 +2,7 @@ > <title>Koha › Circulation › Items overdue as of [% todaysdate %]</title> > [% INCLUDE 'doc-head-close.inc' %] > [% INCLUDE 'calendar.inc' %] >+[%- USE Branches -%] > <script type="text/javascript"> > //<![CDATA[ > function clone_parent(node) { >@@ -106,13 +107,15 @@ overdue as of [% todaysdate %][% IF ( isfiltered ) %] <span style="font-size:70% > <th>Price</th> > </tr></thead> > >+[%- BLOCK subject -%]Overdue:[%- END -%] >+ > <tbody>[% FOREACH overdueloo IN overdueloop %] > <tr> > <td>[% overdueloo.duedate %]</td> > <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% overdueloo.borrowernumber %]">[% overdueloo.surname %][% IF (overdueloo.firstname) %], [% overdueloo.firstname %][% END %] ([% overdueloo.cardnumber %])</a> >- [% IF ( overdueloo.email ) %][<a href="mailto:[% overdueloo.email %]?subject=Overdue: [% overdueloo.title |html %]">email</a>][% END %] >+ [% IF ( overdueloo.email ) %][<a href="mailto:[% overdueloo.email %]?subject=[% INCLUDE subject %] [% overdueloo.title |html %]">email</a>][% END %] > [% IF ( overdueloo.phone ) %]([% overdueloo.phone %])[% ELSIF ( overdueloo.mobile ) %]([% overdueloo.mobile %])[% ELSIF ( overdueloo.phonepro ) %]([% overdueloo.phonepro %])[% END %]</td> >- <td>[% overdueloo.branchcode %]</td> >+ <td>[% IF overdueloo.branchcode %][% Branches.GetName( overdueloo.branchcode ) %][% END %]</td> > <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = overdueloo.biblionumber %][% overdueloo.title |html %] [% overdueloo.subtitle %]</a> [% IF ( overdueloo.author ) %], by [% overdueloo.author %][% END %][% IF ( overdueloo.enumchron ) %], [% overdueloo.enumchron %][% END %] > </td> > <td><a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% overdueloo.biblionumber %]&itemnumber=[% overdueloo.itemnum %]#item[% overdueloo.itemnum %]">[% overdueloo.barcode %]</a></td> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8330
:
39962
|
40083
|
40190