Attachment 40213 Details for Bug 13950 – Bug 13950 - Sort Item search home library list by branch name

[patch] Bug 13950 - Sort Item search home library list by branch name

Bug-13950---Sort-Item-search-home-library-list-by-.patch (text/plain), 1.42 KB, created by Jonathan Druart on 2015-06-17 07:58:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-06-17 07:58:20 UTC

Size: 1.42 KB

patch

obsolete

>From 04b37f276a3f2adf3e05120d3782c071437e2dd6 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@quecheelibrary.org>
>Date: Tue, 16 Jun 2015 21:48:18 -0400
>Subject: [PATCH] Bug 13950 - Sort Item search home library list by branch name
>
>On the item search form the list of home libraries isn't sorted
>alphabetically by their descrption.
>
>To test:
>- Ensure that you have libraries whose code/name are sorted in a different alphabetical order (e.g. Aardvark/ZZZ & Zebra/AAA)
>- Staff: Advanced search - item search
>- See that libraries are sorted in code order
>- Apply patch
>- Verify selection block for home library is correctly sorted after
>  applying the patch.
>
>Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>---
> catalogue/itemsearch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/catalogue/itemsearch.pl b/catalogue/itemsearch.pl
>index e66aa4f..f4e70ea 100755
>--- a/catalogue/itemsearch.pl
>+++ b/catalogue/itemsearch.pl
>@@ -242,7 +242,7 @@ if ($format eq 'html') {
> 
>     my $branches = GetBranches();
>     my @branches;
>-    foreach my $branchcode (keys %$branches) {
>+    foreach my $branchcode ( sort { uc($branches->{$a}->{branchname}) cmp uc($branches->{$b}->{branchname}) } keys %$branches) {
>         push @branches, {
>             value => $branchcode,
>             label => $branches->{$branchcode}->{branchname},
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 13950: 40008 | 40023 | 40206 | 40211 | 40213