The home library option in the new item search feature needs to be alphabetized. Our system displays the options: All Libraries Leavenworth... Carbondale... Prairie Hills Schools -- Sabetha... Lyndon... and so on.
Created attachment 40008 [details] [review] Bug 13950: Sort Item search home library list by branch name On the item search form the list of home libraries isn't sorted alphabetically by their descrption. To test: - Staff: Advanced search - item search - Verify pull down for home library is correctly sorted after applying the patch.
Created attachment 40023 [details] [review] [Signed-off] Bug 13950: Sort Item search home library list by branch name On the item search form the list of home libraries isn't sorted alphabetically by their descrption. To test: - Staff: Advanced search - item search - Verify pull down for home library is correctly sorted after applying the patch. Signed-off-by: Marc Véron <veron@veron.ch>
It does not work, this patch makes the items sorted by branch codes, not branch names. Which is what we want, I guess.
I was struggling a bit with this one and copied the wrong bit of code from somewhere I think - can you take a look and provide a better patch or some hints?
Created attachment 40206 [details] [review] Bug 13950 - Sort Item search home library list by branch name On the item search form the list of home libraries isn't sorted alphabetically by their descrption. To test: - Ensure that you have libraries whose code/name are sorted in a different alphabetical order (e.g. Aardvark/ZZZ & Zebra/AAA) - Staff: Advanced search - item search - See that libraries are sorted in code order - Apply patch - Verify selection block for home library is correctly sorted after applying the patch.
Created attachment 40211 [details] [review] Bug 13950 - Sort Item search home library list by branch name On the item search form the list of home libraries isn't sorted alphabetically by their descrption. To test: - Ensure that you have libraries whose code/name are sorted in a different alphabetical order (e.g. Aardvark/ZZZ & Zebra/AAA) - Staff: Advanced search - item search - See that libraries are sorted in code order - Apply patch - Verify selection block for home library is correctly sorted after applying the patch. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Thx Nick and Indranil :)
Created attachment 40213 [details] [review] Bug 13950 - Sort Item search home library list by branch name On the item search form the list of home libraries isn't sorted alphabetically by their descrption. To test: - Ensure that you have libraries whose code/name are sorted in a different alphabetical order (e.g. Aardvark/ZZZ & Zebra/AAA) - Staff: Advanced search - item search - See that libraries are sorted in code order - Apply patch - Verify selection block for home library is correctly sorted after applying the patch. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Patch pushed to master. Thanks Nick!
Pushed to 3.20.x will be in 3.20.2
Pushed to 3.18.x will be in 3.18.09
Patch not pushed 3.16.x branch, due to conflicts