Attachment 40679 Details for Bug 14465 – [PASSED QA][3.18.x] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout

[patch] [PASSED QA][3.18.x] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout

PASSED-QA-Bug-14465---Broken-umlautsdiacritics-in-.patch (text/plain), 1.91 KB, created by Katrin Fischer on 2015-06-26 15:28:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-06-26 15:28:11 UTC

Size: 1.91 KB

patch

obsolete

>From 2d8c9969d14d00b2146422a0d37b111eaec37570 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 25 Jun 2015 12:54:51 -0400
>Subject: [PATCH] [PASSED QA] Bug 14465 - Broken umlauts/diacritics in
> feedback of last checkout
>
>This was tested in 3.18 after upgrading to the security release. The
>feedback on the last checkout information introcuded by bug 13315 has
>encoding problems in the displayed title (see screenshot).
>
>This is a really prominent place to display broken encoding.
>
>Test Plan:
>1) Apply this patch
>2) Check out an item with broken encoding
>3) Note the title now displays properly
>
>Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>We already put it in production... so this better works :)
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 681dbff..09c1d30 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -1,6 +1,7 @@
> [% USE Koha %]
> [% USE Branches %]
> [% USE KohaDates %]
>+[% USE EncodeUTF8 %]
> [% IF Koha.Preference('ExportRemoveFields') OR Koha.Preference('ExportWithCsvProfile') %]
>    [% SET exports_enabled = 1 %]
> [% END %]
>@@ -596,7 +597,7 @@ No patron matched <span class="ex">[% message %]</span>
> </fieldset>
> [% IF ( issue ) %]
>     <div class="lastchecked">
>-        <p><strong>Checked out: </strong>[% issue.item.biblio.title %] ([% issue.item.barcode %]). Due on [% issue.date_due | $KohaDates %]</p>
>+        <p><strong>Checked out: </strong>[% issue.item.biblio.title | $EncodeUTF8 %] ([% issue.item.barcode %]). Due on [% issue.date_due | $KohaDates %]</p>
>     </div>
> [% END %]
> </form></div>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14465: 40650 | 40651 | 40655 | 40656 | 40679